Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button interrupt review #129

Closed
charlespax opened this issue Jan 22, 2017 · 2 comments
Closed

Button interrupt review #129

charlespax opened this issue Jan 22, 2017 · 2 comments
Milestone
Milestone 4.x

Comments

@charlespax
Copy link
Member

charlespax commented Jan 22, 2017 •
edited
Loading

Go through all the buttons and ensure they are on individual interrupts.

See also PaxInstruments/PaxInstruments-LabWiz-firmware#10 and PaxInstruments/PaxInstruments-LabWiz-firmware#12
@charlespax charlespax added this to the Milestone 4 milestone Jan 22, 2017
@charlespax
Copy link
Member Author

In commit 27a1f19

SW_PWR, GPIO_EXTI0
SW_A, GPIO_EXTI9
SW_B, GPIO_EXTI8
SW_C, GPIO_EXTI9
SW_D, GPIO_EXTI10
SW_E, GPIO_EXTI2

There is a collision between the interrupts of SW_B and SW_D. Both PC1 and PC4 are available and are suitable for replacing one of the EXTI9 lines. PC1 is on the side of the microcontroller that faces SW_A and SW_C, so that is probably a good choice. PC1 is on the top, so I think it would route nicely over to SW_A.

@charlespax
Copy link
Member Author

Swapped WIFI_EN with SW_A to avoid interrupt sharing.

@charlespax charlespax mentioned this issue Jan 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 4.x
Development

No branches or pull requests
1 participant
@charlespax