Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that SideShift transactions are detected correctly as 'success' on the client #819

Open
Klakurka opened this issue Feb 12, 2024 · 0 comments
Assignees
Labels
enhancement (behind the scenes) Stuff that users won't see enhancement (UI/UX/feature) New feature or request
Milestone

Comments

@Klakurka
Copy link
Member

Klakurka commented Feb 12, 2024

This is actually trickier than before as we now rely on OP_RETURN which isn't supported by SideShift.

We could possibly add some extra handling on SideShift txs but it would require using their deeper API integration (instead of the simple pop-up one). However we do this, we'll need to client to also recognize that the transaction was via SideShift for a particular amount and that it's somehow associated with them (eg. we can pass them back the SideShift invoice ID if it knows that) since we won't be able to rely on the payment ID in OP_RETURN.

This feels very "custom BIP70"-y to me but might be unavoidable. Lots of opportunity to be clever here with how we approach it.

Related to #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement (behind the scenes) Stuff that users won't see enhancement (UI/UX/feature) New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants