Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #3

Closed
peter279k opened this issue May 31, 2018 · 7 comments
Closed

Code review #3

peter279k opened this issue May 31, 2018 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@peter279k
Copy link
Member

peter279k commented May 31, 2018

As title.
@Bilge, I use the Porter to implement the CoinAPI.

If possible, can you help me reviewing the code in this repository?

Thanks and I will appreciate your help.

@peter279k peter279k added the help wanted Extra attention is needed label May 31, 2018
@Bilge
Copy link

Bilge commented May 31, 2018

Absolutely, I'll take a look at some point today. Is there a PR or is it the entire repository?

@peter279k
Copy link
Member Author

This is our initialized repository.
If possible, I would like you review the entire repository.

Thanks.

@Bilge
Copy link

Bilge commented May 31, 2018

I can definitely see a few problems but it's difficult to review a repository. GitHub only supports reviewing PRs. Maybe you could turn it into a PR somehow? If you create a branch with an empty commit and then create a PR merging master into that branch, that should work.

@peter279k
Copy link
Member Author

@Bilge, if possible, can you fork the repo and send the PR?

Thanks.

@Bilge
Copy link

Bilge commented May 31, 2018

I'm not going to write any code, just write a review, so it would make sense for you to create the PR so you can make changes to the code (and have it re-reviewed if necessary).

@peter279k
Copy link
Member Author

Please visit this link to do the code review.

Thanks.

@peter279k
Copy link
Member Author

peter279k commented Jun 7, 2018

It squashes the commits and merges in this PR #6 .
This issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants