-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review #3
Comments
Absolutely, I'll take a look at some point today. Is there a PR or is it the entire repository? |
This is our initialized repository. Thanks. |
I can definitely see a few problems but it's difficult to review a repository. GitHub only supports reviewing PRs. Maybe you could turn it into a PR somehow? If you create a branch with an empty commit and then create a PR merging master into that branch, that should work. |
@Bilge, if possible, can you fork the repo and send the PR? Thanks. |
I'm not going to write any code, just write a review, so it would make sense for you to create the PR so you can make changes to the code (and have it re-reviewed if necessary). |
Please visit this link to do the code review. Thanks. |
It squashes the commits and merges in this PR #6 . |
As title.
@Bilge, I use the
Porter
to implement the CoinAPI.If possible, can you help me reviewing the code in this repository?
Thanks and I will appreciate your help.
The text was updated successfully, but these errors were encountered: