Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Weird line breaks in TOC #18

Open
hmosvoll opened this issue Jul 17, 2018 · 2 comments
Open

Fix: Weird line breaks in TOC #18

hmosvoll opened this issue Jul 17, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@hmosvoll
Copy link
Contributor

hmosvoll commented Jul 17, 2018

Describe the bug
The line height and margin between the list items is the same. The space between the list items is now only based on the global line height.

body {
font-family: @font-stack;
font-size: @base-font-size;
line-height: 1.75rem;
color: @text-color;
background-color: @body-bg;
min-height: 100%;
}

Should we have 1.75 line height base?
Won't this make it harder to work with text in components, and cause a loot of overriding?
This will affect text of different sizes, to inherit the line-height of the body font-size (16px).
Every element with a custom text size will now also need a custom line-height to not end up with a 1.75 line-height for 16px. In other words, an element with font-size 100px and font-size 10px will now have the same line-height.

To Reproduce

  1. Go to developer.payex.com
  2. Navigate to Documentation
  3. Resize window to produce line breaks in the TOC

Screenshots
screen shot 2018-07-17 at 15 43 17

Desktop:

  • OS: MAC
  • Browser Chrome
  • Version 67
@hmosvoll hmosvoll added the help wanted Extra attention is needed label Jul 23, 2018
@hmosvoll
Copy link
Contributor Author

After some input from @asbjornu; removing the unit (rem) will fix the text-with-different-sizes-issue mentioned above (https://stackoverflow.com/a/12304722/61818). Stil a question if we should have the default at 1.75 though.

@erikhallaraaker erikhallaraaker changed the title Weird line breaks in TOC Fix: Weird line breaks in TOC Oct 31, 2018
@Akswii
Copy link
Contributor

Akswii commented May 20, 2019

We will need to look into this, but this relates to a bigger issue with overall spacing between components. #265. This might break a lot of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants