Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redsys: DsOrder #14

Closed
mashware opened this issue Jan 21, 2015 · 2 comments
Closed

Redsys: DsOrder #14

mashware opened this issue Jan 21, 2015 · 2 comments

Comments

@mashware
Copy link
Contributor

I am unable to find a way to get DsOrder in events:

  • onPaymentOrderSuccess
  • onPaymentOrderFail

Only way i did, was adding in RedsysManager, line 160 (setDsOrder($dsOrder)):

$redsysMethod
            ->setDsResponse($dsResponse)
            ->setDsAuthorisationCode($dsAuthorisationCode)
            ->setDsCardCountry($dsCardCountry)
            ->setDsConsumerLanguage($dsConsumerLanguage)
            ->setDsDate($dsDate)
            ->setDsHour($dsHour)
            ->setDsSecurePayment($dsSecurePayment)
            ->setDsCardType($dsCardType)
            ->setDsOrder($dsOrder);

And RedsysMethod:

/**
     * Set Order payment
     *
     * @param string $dsOrder
     *
     * @return RedsysMethod self Object
     */
    public function setDsOrder($dsOrder)
    {
        $this->dsOrder = $dsOrder;

        return $this;
    }

    /**
     * Get Order payment
     *
     * @return string
     */
    public function getDsOrder()
    {
        return $this->dsOrder;
    }
@mickaelandrieu
Copy link
Contributor

Hi, looks like we have an improvement here :)

Can you consider to make a pull request ?

Regards (/c @mmoreram )

@mashware
Copy link
Contributor Author

Pull request done!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants