Setup CodeQL for SAST #65
Conversation
Setup CodeQL for SAST
Commit to add CodeQL workflow for Static App Security Testing.
Description
-----------
Commit to add CodeQL workflow for Static App Security Scanning.
Motivation and Context
----------------------
This commit allows us to run Github CodeQl as Github Actions and use CodeQL as a Static Application Security Testing tool to identify security vulnerabilities in code before it gets merged to `master` and deployments made.
Acceptance Criteria
-------------------
Screenshots (if appropriate)
----------------------------
Types of changes
----------------
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
---------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
- [x] My pull request addresses exactly one patch/feature.
- [x] I have created a branch for this patch/feature.
- [x] Each individual commit in the pull request is meaningful. (Please rebase, removing useless commits if not)
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [x] My code follows the code style of this project.
- [ ] My change requires change(s) to the environment.
<!--- Describe the environment changes if any-->
- [ ] My change requires change(s) to the database.
<!--- Describe the database changes if any-->
- [ ] Other information.
Generated by 🚫 Danger Swift against 5dcfb0a |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ahmed-paystack @Peter-John-paystack please help review 🙏🙏 |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: [ 'cpp' ] |
There was a problem hiding this comment.
@eyitemi-paystack So the problem with CodeQL is that its not scanning our files correctly as we use ObjC and Swift. I have spoke to Jocelyn about this and she said if we are using Sonar to scan this repo which we are already for security vulnerabilities then it should be fine. Ill confirm with her and maybe if you can also check with her 😊
There was a problem hiding this comment.
@eyitemi-paystack this is the link to Sonar Cloud for this repo for context, https://sonarcloud.io/summary/new_code?id=PaystackHQ_paystack-ios
There was a problem hiding this comment.
@Peter-John-paystack yeah, so CodeQl doesn't have full coverage for ObjC at te moment and that's why it's not scanning correctly. Sonar works just fine till we come to a solution. The solution might even be to just use Sonar for all mobile repos
There was a problem hiding this comment.
@eyitemi-paystack Awesome, thats what I spoke to Jocelyn about so if the security team is happy, we will be using Sonar for all mobile repos. Can we then close this PR? cc: @ahmed-paystack
There was a problem hiding this comment.
Yes, please. Let's close this PR.
Setup CodeQL for SAST
Commit to add CodeQL workflow for Static App Security Testing.
Description
Commit to add CodeQL workflow for Static App Security Scanning.
Motivation and Context
This commit allows us to run Github CodeQl as Github Actions and use CodeQL as a Static Application Security Testing tool to identify security vulnerabilities in code before it gets merged to
masterand deployments made.Acceptance Criteria
Screenshots (if appropriate)
Types of changes
Checklist
Fixes #0 (Enter the number for the issue this fixes. If you have not yet created an issue, please do so now or delete this line if you are only submitting a patch)
Changes made by this pull request