Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read.output.R #1887

Closed
tonygardella opened this issue Mar 26, 2018 · 0 comments
Closed

Update read.output.R #1887

tonygardella opened this issue Mar 26, 2018 · 0 comments

Comments

@tonygardella
Copy link
Contributor

read.output handles "start.year" differently than we normally do deal with dates (ie "2004/01/01").

#1785 was made to document the difference but we need a code change.

Mike made the comment: I'd prefer to fix the code than fix the documentation. I think we want the code to be flexible enough to read either character or numeric years, and then convert numeric years to character internally. I don't think we want to go in the other direction (char -> num) since pre-1000AD the leading zeros become important.

Tess responded: My edit to the documentation was mostly just trying to convey that it didn't have to be, and won't accept a full "yyyy/mm/dd" sequence. Some of the other functions (load_data?) need a full sequence.
I bet it does only take a character though. I can double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants