Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate import logic #133

Open
OleksandrSPV opened this issue May 8, 2024 · 4 comments · Fixed by #164
Open

Add certificate import logic #133

OleksandrSPV opened this issue May 8, 2024 · 4 comments · Fixed by #164
Assignees

Comments

@OleksandrSPV
Copy link
Collaborator

No description provided.

@OleksandrSPV OleksandrSPV changed the title Add certificate deletion logic Add certificate import logic May 8, 2024
@OleksandrSPV
Copy link
Collaborator Author

@donskov Do you plan to have a method for import certificate in @peculiar/fortify-client-core? Or is there way to import certificate with creation methods. Could you help please?

@donskov
Copy link
Collaborator

donskov commented Jun 14, 2024

@OleksandrSPV I don't think we need it in this particular library. It was created just to make working with Fortify and the web-component a little easier. You will need to do the import yourself.
To do this you need:

  1. Find current provider (https://github.com/PeculiarVentures/fortify-webcomponents/blob/master/packages/client-core/src/fortify_api.ts#L726).
  2. Import certificate to provider using provider.certStorage.importCert method.

@OleksandrSPV
Copy link
Collaborator Author

@donskov Thanks, I'ii check

@OleksandrSPV
Copy link
Collaborator Author

@donskov I tried this method and it seemed to work. I did it in this branch https://github.com/PeculiarVentures/fortify-tools/tree/aslobodian/v2-certificate-import-logic-1, but I don’t want to open a PR now, because we should merge this #150 first, thanks

@OleksandrSPV OleksandrSPV self-assigned this Jun 19, 2024
@OleksandrSPV OleksandrSPV linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants