Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability checks #65

Open
shamilovtim opened this issue Mar 26, 2024 · 0 comments
Open

Fix nullability checks #65

shamilovtim opened this issue Mar 26, 2024 · 0 comments

Comments

@shamilovtim
Copy link
Contributor

shamilovtim commented Mar 26, 2024

In JS the following holds true:

const foo = { maybe: undefined };
const bar = {};

> "maybe" in foo;
true
> "maybe" in bar;
false

This library uses nullability checks such that (e.g.)!("tagLength" in algorithm) which causes unhandled exceptions when the key exists but is undefined

@shamilovtim shamilovtim changed the title Fix nullability checks in AesGcmProvider Fix nullability checks Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant