Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Force Model parameters use wrong naming pattern #1415

Open
schroedtert opened this issue May 17, 2024 · 1 comment
Open

Social Force Model parameters use wrong naming pattern #1415

schroedtert opened this issue May 17, 2024 · 1 comment
Assignees

Comments

@schroedtert
Copy link
Contributor

For consistency the naming of the parameters of the Social Force Model should be snake_case as everywhere else.

Hence, create new properties for wrongly named parameters with the correct names and mark the old ones as deprecated. This should then also be ensured with tests, that everything works as intended. If possible add also a ruff check for checking the naming patterns (if only here ignored).

@chraibi
Copy link
Contributor

chraibi commented May 17, 2024

I also noticed that desiredSpeed is actually called v0 in other models. That confused me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants