Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mmol/l doesn't seem to be working #14

Open
Loquacity opened this issue Jan 30, 2023 · 4 comments
Open

Switch to mmol/l doesn't seem to be working #14

Loquacity opened this issue Jan 30, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Loquacity
Copy link

Loquacity commented Jan 30, 2023

Set as mmol/l:

image

Set as mg/dl:

image

Taskbar icon for both settings:

image

It looks as though it's still showing in mg/dl, but adding in a decimal place?

@chasepeeler
Copy link
Member

I think I know the issue here. The API is returning the data in mg/dL. Selecting the units just adjusts how it determines the y-axis values. I could do the math to convert, but I know there are instances where the API returns mmol/L data, which would cause that to break.

When I changed my instance to display mmol/L, the API still returned mg/dL data. Let me dig some more and see if I can figure out how to force it to return mmol/L data.

@chasepeeler
Copy link
Member

Okay, I found a fix. I'll try and get it out tonight.

@chasepeeler chasepeeler added the bug Something isn't working label Jan 31, 2023
@chasepeeler chasepeeler self-assigned this Jan 31, 2023
@chasepeeler
Copy link
Member

This should be resolved in the attached version (or you can grab the 14-switch-to-mmoll-doesnt-seem-to-be-working branch if you want to build it yourself)

I don't have it working yet to where it will trigger an API call after you save the settings. I was going to do that now, but I had surgery on my hand Friday and typing isn't super easy at the moment. Once I get that done, I'll create a new release. Until then you can either wait 5 minutes for the next API call, or just quit and restart the program.

GlucoseViewer 2023-01-31 19-06-11.zip

@peterlynton If you get a chance, could you grab the above version and make sure it's still working properly for you?

@Loquacity
Copy link
Author

Excellent, thanks! I've got the new version running, will let you know how it goes 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants