Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer Feature: Fetch signed transactions list #528

Merged
merged 51 commits into from
Apr 19, 2023
Merged

Signer Feature: Fetch signed transactions list #528

merged 51 commits into from
Apr 19, 2023

Conversation

GuillemGarciaDev
Copy link
Contributor

@GuillemGarciaDev GuillemGarciaDev commented Apr 12, 2023 •
edited
Loading

Signer Feature: Fetch signed transactions list

Issues

closes #503

Dependencies

#527 (Depends on SDK calls in order to sign the transaction requests)

Changes

  • Added service to useGetsignedTransactions (gets all TransactionRequest with status = "signed", current network and address)
  • useGetSignedFullTransactions custom hook (from the query above, takes all transaction hashes and gets the FullTransaction of each one using the serviceInstance)
  • testing + locale update

IMG_9007
IMG_9006

GuillemGarciaDev and others added 24 commits March 27, 2023 11:20
@GuillemGarciaDev
adding transactionRequestScreen
19cb54f
@GuillemGarciaDev
TransactionRequestModal WIP
41f943a
@GuillemGarciaDev
Merge branch 'signer/fetch-pending-transaction-requests' into signer/…
ad86b40 
…transaction-request-modal
@GuillemGarciaDev
TransactionRequestModal working
92270b6
@GuillemGarciaDev
Components testing
3567f5a
@GuillemGarciaDev
final tests
74d806b
@GuillemGarciaDev
Transaction Request Modal fixes
6da9cda
@GuillemGarciaDev
Controlled reject dialog
60852be
@GuillemGarciaDev
final commit with new fixes and tests
5e6d1ce
@GuillemGarciaDev
linting fixes
49be698
@GuillemGarciaDev
Show WalletSelector on SignInRequestModal
46ad77c
@GuillemGarciaDev
Merge branch 'signer/fetch-pending-transaction-requests' into signer/…
fdc3cbf 
…transaction-request-modal
@GuillemGarciaDev
api module updated
b8cc7ac
@GuillemGarciaDev
hotfix
106d701
@GuillemGarciaDev
Merge branch 'signer/fetch-pending-transaction-requests' into signer/…
0880853 
…transaction-request-modal
@GuillemGarciaDev
PR Partial Fixes
52c120a
@GuillemGarciaDev
Base transaction summary pending on SDK calls
a4b3799
@GuillemGarciaDev
SignerTransactionSummary with testing
1a4d3c5
@GuillemGarciaDev
hotfix in useGetTransaction
5438043
@GuillemGarciaDev
useGetTransaction comment
7867fd2
@jpeersyst
add get type from partial tx and fill and sign it
006d91e
@GuillemGarciaDev
Signed object list fetching transactions
3fdc3aa
@jpeersyst
add support to identify dao unlock and withdraw from input
642c058
@GuillemGarciaDev
Signed Transactions List
29e59d3
@pullpo-for-slack
Copy link

pullpo-for-slack bot commented Apr 12, 2023 •
edited
Loading

Oupsie! Looks like something went wrong on our end.
We'll investigate it and solve it for future pull requests!

GuillemGarciaDev and others added 20 commits April 12, 2023 09:45
@GuillemGarciaDev
sonarCloud bug fixing
5b6e107
@GuillemGarciaDev
last changes of review
74a60c5
@GuillemGarciaDev
testing + linting fixes
ec1c83c
@GuillemGarciaDev
Merge branch 'signer/fetch-pending-transaction-requests' into signer/…
44fdf1e 
…transaction-request-modal
@GuillemGarciaDev
sonarCloud fix
4f58821
@GuillemGarciaDev
Merge branch 'signer/transaction-request-modal' into signer/transacti…
688fde3 
…on-sdk
@GuillemGarciaDev
Merge branch 'signer/transaction-sdk' of https://github.com/Peersyst/…
07ed329 
…ckbull-mobile into signer/transaction-sdk
@GuillemGarciaDev
Merge branch 'signer-app' into signer/transaction-sdk
edcafc8
@GuillemGarciaDev
library update
0b857e9
@GuillemGarciaDev
Merge branch 'signer/transaction-request-modal' into signer/transacti…
7dbd826 
…on-sdk
@GuillemGarciaDev
transaction SDK fixes applied
9dda01e
@GuillemGarciaDev
Merge branch 'signer-app' of https://github.com/Peersyst/ckbull-mobile …
b785673 
…into signer/transaction-sdk
@GuillemGarciaDev
on sign error reject request
938b9cb
@GuillemGarciaDev
Merge branch 'signer/transaction-sdk' into signer/transaction-summary
9e111cd
@GuillemGarciaDev
transaction summary with amount
5121524
@GuillemGarciaDev
Hook to obtain amount from transaction
0d2ab27
@GuillemGarciaDev
ckb conversion updated in useGetAmountFromTransaction
756284c
@GuillemGarciaDev
Transaction Summary: CKB transaction
d207b8b
@GuillemGarciaDev
Nft Transaction summary with testing
d2186f3
@GuillemGarciaDev
Sends transaction hash after signing
62908d5
@silvap-javier silvap-javier self-assigned this Apr 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GuillemGarciaDev GuillemGarciaDev merged commit b81c4c7 into signer-app Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvap-javier silvap-javier silvap-javier requested changes

@AdriaCarrera AdriaCarrera Awaiting requested review from AdriaCarrera

@JordiParraCrespo JordiParraCrespo Awaiting requested review from JordiParraCrespo

@AgustinMJ AgustinMJ Awaiting requested review from AgustinMJ

Assignees

@silvap-javier silvap-javier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signer Feature: Fetch signed list objects
3 participants
@GuillemGarciaDev @silvap-javier @jpeersyst