Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Create route to get details of a certain pool #49

Closed
kkennis opened this issue Mar 31, 2021 · 1 comment
Closed

API: Create route to get details of a certain pool #49

kkennis opened this issue Mar 31, 2021 · 1 comment
Assignees
Labels

Comments

@kkennis
Copy link
Contributor

kkennis commented Mar 31, 2021

Akin to our v2 route /api/v1/uniswap/pairs/:pairId, we need a route for V3 to get greater details on a specific pair and associated metrics. This route should contain as-close-to-real-time as possible data about the pair, for powering pair details and Add Liquidity experiences in the UI.

This route may also have to calculate some derived stats based on available data and provide those as pair insights. We want at least the below stats:

  • Contract address of the pool
  • Current price of pool
  • Liquidity distribution of pool
  • Number of unique liquidity providers in pool
  • Fee tier of pool
  • Creation date of pool
  • Trade volume of pool in notional USD value
  • Trade volume of pool in # of trades
  • Trade distribution of pool
  • Current reserves of each asset in pool
  • Metadata about each token in the pool (address, decimals, symbol, long name)

As with v2, the API route should validate that the passed id is a valid ETH address, and should return appropriate error events if the pool could not be found.

Acceptance Criteria:

  • Route exposed to get pair details for v3
  • Route validates pairId is a valid ETH address
  • Route returns pair details with fields specified above
  • API Integration tests written for route
@khcoaching
Copy link
Contributor

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants