Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: As a user, I want to be able to withdraw my liquidity #55

Open
kkennis opened this issue Apr 1, 2021 · 1 comment
Open

UX: As a user, I want to be able to withdraw my liquidity #55

kkennis opened this issue Apr 1, 2021 · 1 comment

Comments

@kkennis
Copy link
Contributor

kkennis commented Apr 1, 2021

This is a companion task to #52 - the 'remove liquidity' converse to 'add liquidity'. Users should be able to fully manage their liquidity lifecycle on Sommelier, which includes the removal step.

This will be much simpler than add liquidity - as an MVP, they should only be able to remove 100% of their liquidity, in essence, burn their NFLP.

Updating their position atomically is out of scope. Users can update their positions by removing liquidity and adding liquidity separately, which are flows we will already support.

The user needs a flow where they can:

  1. Select a pool from their open positions
  2. Choose to remove the liquidity
  3. Confirm the details of their action and submit their transaction

This task should also cover the needed contract interactions and approvals, if needed.

Acceptance Criteria:

  • An end-to-end flow where a user with a liquidity position can generate and send a transaction, and end up with their individual tokens from the pool.
@kkennis
Copy link
Contributor Author

kkennis commented Apr 20, 2021

Launch day thought: maybe we have a Remove button, but it's just a deep-link to remove on the Uniswap V3 app? That way we don't need to build anything special, and there is no 'simplifying the experience' we are doing for remove anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant