Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebalance call ABI and test to allocation #41

Closed
jackzampolin opened this issue May 29, 2021 · 3 comments
Closed

Add rebalance call ABI and test to allocation #41

jackzampolin opened this issue May 29, 2021 · 3 comments

Comments

@jackzampolin
Copy link
Contributor

https://github.com/VolumeFi/cellars/blob/main/contracts/CellarPoolShare.sol#L491

@jackzampolin jackzampolin mentioned this issue May 29, 2021
27 tasks
@taariq
Copy link
Contributor

taariq commented Jun 2, 2021

@jackzampolin We can pack it as a tuple array.
https://docs.soliditylang.org/en/v0.7.6/abi-spec.html#handling-tuple-types. You good to go here or is more needed?

@webelf101
Copy link

{ "inputs": [ { "components": [ { "internalType": "uint184", "name": "tokenId", "type": "uint184" }, { "internalType": "int24", "name": "tickUpper", "type": "int24" }, { "internalType": "int24", "name": "tickLower", "type": "int24" }, { "internalType": "uint24", "name": "weight", "type": "uint24" } ], "internalType": "struct ICellarPoolShare.CellarTickInfo[]", "name": "_cellarTickInfo", "type": "tuple[]" } ], "name": "rebalance", "outputs": [], "stateMutability": "nonpayable", "type": "function" }

This is ABI of rebalance function. Is this enough?

@taariq
Copy link
Contributor

taariq commented Jun 4, 2021

@jackzampolin FYI. Let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants