You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on the code below, it looks like QCPlot uses the filtered framewise displacement values in both the preprocessing and postprocessing carpet+line plots. This is probably misleading to users, since it seems like no filtering was done between the two versions.
@madisoth corrected me on this- we don't want to show unfiltered FD for preprocessed data and filtered for postprocessed data, because the filtered FD is only used for censoring; it's not used for denoising. As such, we want to show the unfiltered FD in both plots. #579 adds a new censoring plot to the summary reports, so users should be less confused.
As it turns out, they DCAN team does want us to use the filtered FD for denoising. Not sure why they wanted us to only show unfiltered FD in the plots.
tsalo
changed the title
QCPlot shows FD after filtering
[DCAN] QCPlot shows FD after filtering
Jun 7, 2023
Summary
Based on the code below, it looks like QCPlot uses the filtered framewise displacement values in both the preprocessing and postprocessing carpet+line plots. This is probably misleading to users, since it seems like no filtering was done between the two versions.
xcp_d/xcp_d/interfaces/qc_plot.py
Lines 104 to 119 in d4f8bd0
The text was updated successfully, but these errors were encountered: