Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] Lowering custom calls #367

Merged
merged 128 commits into from Dec 28, 2023
Merged

[MLIR] Lowering custom calls #367

merged 128 commits into from Dec 28, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Nov 17, 2023 •
edited by dime10

Context:
Some Jax function are lowered to custom calls to external libraries (e.g. Lapack)

Description of the Change:

Benefits:

  • We can use any function from Lapack.
  • Unlock polyfit from Jax.

[sc-46449]

@rmoyard
Draft structure
fd951ca
@rmoyard
Merge branch 'main' into mitigation_dialect
c9e35c1
@rmoyard
Remove mac os changes
ff341d6
@rmoyard
Valid ZNE op
ee74fd5
@rmoyard
ZNE lowering draft
5561555
@rmoyard
Structure folded
50fbe4a
@rmoyard
Merge branch 'main' into mitigation_dialect
31ded39
@rmoyard
Update
08899b4
@rmoyard
Merge branch 'mitigation_dialect' of https://github.com/PennyLaneAI/c…
3144958 
…atalyst into mitigation_dialect
@rmoyard
Update
ed461a6
@rmoyard
Update with functions
ee918d2
@rmoyard
For loop for the index (fn, adjoint)**n
01ab781
@rmoyard
Working prototype
f8b5524
@rmoyard
Merge branch 'main' into mitigation_dialect
4fb4974
@rmoyard
Draft
edd2dc6
@rmoyard
Update
c085027
@rmoyard
Update example
dd39009
@rmoyard
Update
0d557de
@rmoyard
Working version
a56e5c6
@rmoyard
Merge branch 'main' into mitigation_dialect
ec08d64
@rmoyard
Handle classical call op
61a4d48
@rmoyard
Merge branch 'main' into adjoint_call_op
0422fd7
@rmoyard
Typos
2cf8693
@rmoyard
Merge branch 'main' into adjoint_call_op
1115d45
@rmoyard
Changelog
4a0765c
@rmoyard
Cleanup
86f8214
@rmoyard
Add tests
c6a97ff
@rmoyard
Formatting
b5e2023
@rmoyard
Merge branch 'main' into mitigation_dialect
0f7a32c
@rmoyard
Merge branch 'adjoint_call_op' into mitigation_dialect
1147334
@rmoyard
Copy link
Contributor Author

rmoyard commented Dec 22, 2023

MacOs wheels are passing: https://github.com/PennyLaneAI/catalyst/actions/runs/7301635442 and https://github.com/PennyLaneAI/catalyst/actions/workflows/build-wheel-macos-x86_64.yaml

dime10
dime10 requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting this to work 💯

I don't think there are any major blockers.

.github/workflows/build-wheel-linux-x86_64.yaml Show resolved Hide resolved
frontend/catalyst/compiler.py Outdated Show resolved Hide resolved
frontend/catalyst/compiler.py Outdated Show resolved Hide resolved
frontend/catalyst/compiler.py Outdated Show resolved Hide resolved
frontend/catalyst/compiler.py Outdated Show resolved Hide resolved
mlir/lib/Catalyst/Transforms/BufferizationPatterns.cpp Outdated Show resolved Hide resolved
mlir/lib/Catalyst/Transforms/catalyst_to_llvm.cpp Show resolved Hide resolved
mlir/lib/Catalyst/Transforms/catalyst_to_llvm.cpp Show resolved Hide resolved
mlir/lib/Catalyst/Transforms/catalyst_to_llvm.cpp Show resolved Hide resolved
mlir/lib/Catalyst/Transforms/catalyst_to_llvm.cpp Outdated Show resolved Hide resolved
rmoyard and others added 6 commits December 27, 2023 23:26
@rmoyard @dime10 @maliasadi
Apply suggestions from code review
719755c 
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Co-authored-by: Ali Asadi <ali@xanadu.ai>
@rmoyard
From review
e28629f
@rmoyard
Trigger CI
927aa89
@rmoyard
Update library name
01dcc72
@rmoyard
Update
c806104
@rmoyard
Changelog
7f87906
dime10
dime10 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@rmoyard rmoyard merged commit f19e152 into main Dec 28, 2023
39 of 40 checks passed
@rmoyard rmoyard deleted the support_polyfit branch December 28, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliasadi maliasadi maliasadi left review comments

@erick-xanadu erick-xanadu erick-xanadu left review comments

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
compiler Pull requests that update the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rmoyard @maliasadi @dime10 @erick-xanadu