Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define decomposition for qml.ControlledQubitUnitary #2322

Open
antalszava opened this issue Mar 14, 2022 · 4 comments
Open

Define decomposition for qml.ControlledQubitUnitary #2322

antalszava opened this issue Mar 14, 2022 · 4 comments
Labels
enhancement ✨ New feature or request

Comments

@antalszava
Copy link
Contributor

Feature details

Logic to decompose qml.ControlledQubitUnitary would be great to have. One potential solution could be to regard qml.ControlledQubitUnitary as a qml.QubitUnitary and use the decomposition of QubitUnitary (note: that this is only defined for the two-qubit case).

Also see #2320.

Implementation

No response

How important would you say this feature is?

1: Not important. Would be nice to have.

Additional information

No response

@antalszava antalszava added the enhancement ✨ New feature or request label Mar 14, 2022
@MoritzWillmann
Copy link
Contributor

Hey @antalszava, I just started looking into this and would like to work on this, if that's okay. I quite like the Idea of using QubitUnitary.compute_decomposition. Do you think the ability to only use it for two-qubit gates would be a big limitation to functionality?

@antalszava
Copy link
Contributor Author

Hi @MoritzWillmann, apologies for the delayed response here! For sure, feel free to go for it. 🙂

Using QubitUnitary.compute_decomposition could be a good short-term solution. Overall having a more general approach would be desirable.

@MoritzWillmann
Copy link
Contributor

Hi @antalszava, sorry for the super delayed response 😞
Just to clarify, do you mean having a more general approach just for the ControlledQubitUnitary or use the QubitUnitary.compute_decomposition and have a more general approach for that?

@antalszava
Copy link
Contributor Author

Hi @MoritzWillmann, a bit of both 🙂 Specifically here, extending ControlledQubitUnitary would be desired, though if I recall correctly QubitUnitary too has limitations on decomposition. This is mainly due to the fact that new techniques would be required (if found by researchers) on how arbitrary unitaries can be decomposed using elementary gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants