Allow tuple-valued control_values with qml.ctrl on a Controlled instance.
#5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5725 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 416 416
Lines 39053 38763 -290
==========================================
- Hits 38929 38638 -291
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
dwierichs
added
the
review-ready 👌
dwierichs
commented
May 23, 2024
mudit2812
approved these changes
May 23, 2024
dwierichs
commented
May 23, 2024
lillian542
approved these changes
May 23, 2024
dwierichs
added
merge-ready ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
By default,
control_valuesofControlledinstances are lists.qml.defer_measurementspasses a tuple ascontrol_valuestoctrl.create_controlled_op, called byctrl, tries to mergecontrol_valuesof the base operation and the providedcontrol_values.The consequence is an attempted addition of
listandtuple, ifqml.defer_measurementshits aqml.condof aControlledinstance, leading to #5717Description of the Change:
This PR fixes the above problem in two (redundant!) ways:
control_valuestoctrl, which casts them to alist.defer_measurementspasses alistitself.Clearly those changes are redundant for the bug #5717, with the former also providing users with the option of using
tuples forcontrol_values. We could skip the change todefer_measurements, thus.Benefits:
Possible Drawbacks:
Related GitHub Issues:
Fixes #5717
[sc-63645]