Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quantum monte carlo #4708

Merged
merged 16 commits into from Dec 15, 2023
Merged

Update quantum monte carlo #4708

merged 16 commits into from Dec 15, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Oct 23, 2023 •
edited

Description of the Change:

  • Update the quantum monte carlo to the new transform system
  • Upadte applied_controlle_Q to the new transform system
  • Update the documentation

Benefits:

The transform can now be applied directly on QNodes.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90e9b5b) 99.49% compared to head (ca3858f) 99.49%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4708      +/-   ##
==========================================
- Coverage   99.49%   99.49%   -0.01%     
==========================================
  Files         388      390       +2     
  Lines       35513    35265     -248     
==========================================
- Hits        35335    35088     -247     
+ Misses        178      177       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

timmysilv
timmysilv approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some non-blocking style concerns, but lgtm!

pennylane/transforms/qmc.py Outdated Show resolved Hide resolved
pennylane/transforms/qmc.py Outdated Show resolved Hide resolved
pennylane/transforms/qmc.py Outdated Show resolved Hide resolved
pennylane/transforms/qmc.py Outdated Show resolved Hide resolved
mudit2812
mudit2812 reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left 2 comments, otherwise ready to approve :)

pennylane/transforms/qmc.py Show resolved Hide resolved
pennylane/transforms/qmc.py Outdated Show resolved Hide resolved
@rmoyard rmoyard enabled auto-merge (squash) December 15, 2023 19:07
@rmoyard rmoyard merged commit 837c5a2 into master Dec 15, 2023
35 checks passed
@rmoyard rmoyard deleted the update_monte_carlo branch December 15, 2023 19:18
mudit2812 pushed a commit that referenced this pull request Jan 19, 2024
@rmoyard @mudit2812
Update quantum monte carlo (#4708)
3482402 
**Description of the Change:**

- Update the quantum monte carlo to the new transform system
- Upadte applied_controlle_Q to the new transform system
- Update the documentation

**Benefits:**

The transform can now be applied directly on QNodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudit2812 mudit2812 mudit2812 approved these changes

@timmysilv timmysilv timmysilv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmoyard @mudit2812 @timmysilv