add process_counts method to SampleMeasurement
#4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Dec 12, 2023
mudit2812
reviewed
Dec 12, 2023
mudit2812
reviewed
Dec 12, 2023
mudit2812
reviewed
Dec 12, 2023
mudit2812
reviewed
Dec 12, 2023
mudit2812
approved these changes
Dec 12, 2023
timmysilv
approved these changes
Dec 12, 2023
|
[sc-51501] |
Co-authored-by: Matthew Silverman <matthews@xanadu.ai> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4941 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.02%
==========================================
Files 388 388
Lines 35360 35096 -264
==========================================
- Hits 35243 34976 -267
- Misses 117 120 +3 ☔ View full report in Codecov by Sentry. |
mudit2812
added a commit
that referenced
this pull request
Jan 19, 2024
This PR adds a `process_counts` method to `SampleMeasurement`. This method is not implemented by anything and only raises a `NotImplementedError`. This method is to make it easier to support plugins and remote devices that prefer producing and sending counts histograms instead of the raw samples. --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
albi3ro
added a commit
that referenced
this pull request
Mar 12, 2024
…5256) **Context:** Under #4941 abstract method `process_counts` was added to `SampleMeasurement`. This method provides support to process counts dictionary produced by external systems. **Description of the Change:** * Implement `process_counts` in `ExpectationMP`, `VarianceMP` and `CountsMP`. * While implementing `process_counts` in `CountsMP` some common logic was extracted from `ProbabilityMP` to `CountsMP` **Benefits:** The below methods won't throw `NotImplementedError` exception * `ExpectationMP.process_counts` * `VarianceMP.process_counts` * `CountsMP.process_counts` **Possible Drawbacks:** * All classes which inherit from `SampleMeasurement` implement `process_counts` except `SampleMP`. Should I add an implementation for that ? * After implementing `process_counts` in all child classes can we make the method abstract similar to `process_samples` ? This might break some tests where some classes inherit from `SampleMeasurement` as there `process_counts` is not implemented * It is assumed that `counts` dictionary is valid and caller is responsible to call with valid dictionary. It has already been discussed in this [conversation](https://github.com/PennyLaneAI/pennylane/pull/4952/files/eb9c1ee81ea87c274a5ec094f90a0065d05fdc36#r1433117236) and this is a design choice. **Related GitHub Issues:** This PR * fixes #5249 * fixes #5244 * fixes #5241 *** **Further details** I'm excited to be making my first open-source contribution with this PR 😄 . As a newcomer to the community, I'm eager to learn and improve. Any feedback for enhancements would be greatly appreciated! **Internal Shortcut Stories** - [sc-57166] - [sc-57274] - [sc-57307] --------- Co-authored-by: Christina Lee <chrissie.c.l@gmail.com> Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
added a commit
that referenced
this pull request
Mar 25, 2024
**Context:** Under #4941 abstract method `process_counts` was added to`SampleMeasurement`. This method provides support to process counts dictionary produced by external systems. **Description of the Change:** * Implement `process_counts` in `SampleMP`. * Make `SampleMeasurement.process_counts` an abstract method **Benefits:** The method `SampleMP.process_counts` won't throw `NotImplementedError` exception **Possible Drawbacks:** **Related GitHub Issues:** Fixes #5371 --------- Co-authored-by: Astral Cai <astralcai@gmail.com> Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
process_countsmethod toSampleMeasurement. This method is not implemented by anything and only raises aNotImplementedError.This method is to make it easier to support plugins and remote devices that prefer producing and sending counts histograms instead of the raw samples.