Remove type hinting check in transforms #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4942 +/- ##
==========================================
- Coverage 99.67% 99.49% -0.19%
==========================================
Files 388 388
Lines 35418 35199 -219
==========================================
- Hits 35302 35020 -282
- Misses 116 179 +63 ☔ View full report in Codecov by Sentry. |
|
[sc-47760] |
rmoyard
changed the title
timmysilv
reviewed
Dec 13, 2023
Co-authored-by: Josh Izaac <josh146@gmail.com>
mudit2812
pushed a commit
that referenced
this pull request
Dec 15, 2023
**Context:** The type hinting check is removed for transforms, in order to make the transform decorator more practical. **Description of the Change:** Remove the type hinting check that would fail if the user does not respect the transform contract. The signature check between the transform and the expand transform is kept. **Benefits:** More practical for advanced users **Possible Drawbacks:** Potentially harder for beginners to create if the contract is not understood. --------- Co-authored-by: Josh Izaac <josh146@gmail.com>
mudit2812
pushed a commit
that referenced
this pull request
Jan 19, 2024
**Context:** The type hinting check is removed for transforms, in order to make the transform decorator more practical. **Description of the Change:** Remove the type hinting check that would fail if the user does not respect the transform contract. The signature check between the transform and the expand transform is kept. **Benefits:** More practical for advanced users **Possible Drawbacks:** Potentially harder for beginners to create if the contract is not understood. --------- Co-authored-by: Josh Izaac <josh146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The type hinting check is removed for transforms, in order to make the transform decorator more practical.
Description of the Change:
Remove the type hinting check that would fail if the user does not respect the transform contract.
The signature check between the transform and the expand transform is kept.
Benefits:
More practical for advanced users
Possible Drawbacks:
Potentially harder for beginners to create if the contract is not understood.