Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set container in directive #4

Closed
alexnaldo opened this issue Jun 23, 2015 · 9 comments
Closed

Set container in directive #4

alexnaldo opened this issue Jun 23, 2015 · 9 comments

Comments

@alexnaldo
Copy link

If I have an image in a second page your code doesn't work because locates for 'window' or 'container' in the main page.

... in config code...

scrollable = document.querySelector('#scrollable')
container: angular.element(scrollable)

@Pentiado
Copy link
Owner

Pull requests are welcome : )

@Jurigag
Copy link

Jurigag commented Jul 31, 2015

+1 Anyone have solution ? Also im not sure but there is this container but in JS is nowhere used :P

@Pentiado
Copy link
Owner

Tomorrow I start my vacation, then I'll jump into this issue : )

@Pentiado
Copy link
Owner

Pentiado commented Aug 2, 2015

I added a directive "lazyImgContainer" which when added to some element as attribute will trigger on scroll "checkImages" the same way as window (or container if set in provider)

@Pentiado Pentiado closed this as completed Aug 2, 2015
@Jurigag
Copy link

Jurigag commented Aug 2, 2015

Nice, i will test it tomorrow and provide some info :D

@Jurigag
Copy link

Jurigag commented Aug 5, 2015

How is it working exactly ? I have div with style like and added directive lazy-img-container:

overflow-y:scroll
height:400px

and in there ng-repeat with div where inside are images, but its not working

@rictorres
Copy link
Contributor

Doesn't work for me either. Tried passing container inside the options object and also attaching lazy-img-container to the scrollable element.

I think this should be reopened :)

@rictorres
Copy link
Contributor

Bower registry has an old version of this module: #8

bower install --save angular-lazy-img#fa48333273f9e

or

bower install --save angular-lazy-img#master

will work for now.

@Pentiado Pentiado reopened this Aug 26, 2015
@Pentiado
Copy link
Owner

Yes, sorry guys I forgot about publishing tag. Now it should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants