Clean rosnode termination. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValerioMagnago
force-pushed
the
terminate_cleanly
branch
from
5d5fde2
to
6c26889
Compare
|
@ValerioMa thanks for the fix! Please make clang happy: https://github.com/PepperlFuchs/pf_lidar_ros_driver/actions/runs/4234784627/jobs/7357573296#step:4:178 |
ValerioMagnago
force-pushed
the
terminate_cleanly
branch
from
6c26889
to
0314eb6
Compare
Before this commit the scan message was stamped just before publishing the data. In the LaserScan message of ros the timestamp in the header is the acquisition time of the first ray in the scan.
The port parameter was declared as an int_t in the cfg files but in the code it is expected to be a string. When the dynamic_reconfigure server is started, the data type on the parameter server was changed from string to int. This resulted in getParam of the release 1.2.0 to return False effectively killing any respawn functionality.
hsd-dev
force-pushed
the
terminate_cleanly
branch
from
97bbf39
to
4aa5b46
Compare
|
behind #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #105