Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host/port logging in Oplog/Resolver.py uses out-of-scope variables #37

Closed
timvaillancourt opened this issue Jul 22, 2016 · 1 comment
Closed

Host/port logging in Oplog/Resolver.py uses out-of-scope variables #37

timvaillancourt opened this issue Jul 22, 2016 · 1 comment

Comments

@timvaillancourt
Copy link
Contributor

Suggested by PEP8, one use of 'host' and 'port' variables in Oplog/Resolver.py is using out-of-scope variables from a previous for-loop, seen here:

https://github.com/Percona-Lab/mongodb_consistent_backup/blob/master/MongoBackup/Oplog/Resolver.py#L89

Fix to use correct host/port values.
@timvaillancourt timvaillancourt changed the title Host/port in Oplog/Resolver.py uses out-of-scope variables Host/port logging in Oplog/Resolver.py uses out-of-scope variables Jul 22, 2016
@timvaillancourt timvaillancourt mentioned this issue Jul 22, 2016
Merged
@timvaillancourt
Copy link
Contributor Author

Resolved by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timvaillancourt