Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set gcAllowVeryLargeObjects for Runtime Settings #76

Closed
AndreyAkinshin opened this issue Jan 19, 2016 · 7 comments
Closed
Assignees
Milestone

Comments

@AndreyAkinshin
Copy link
Member

See MSDN page: Runtime Settings Schema
We can implement some logic that will specify some parameters (e.g. gcAllowVeryLargeObjects, gcConcurrent, gcServer look useful). We can define default values and allow to specify custom values via attributes.

@AndreyAkinshin
Copy link
Member Author

@mattwarren, what do you think?

@mattwarren
Copy link
Contributor

You know what, I was thinking about this the other day, but only the gcConcurrent and gcServer settings. So yes, I think it's a good idea.

I guess you are thinking of adding them to [BenchmarkTask()], like the existing BenchmarkPlatform and BenchmarkJitVersion options?

@AndreyAkinshin
Copy link
Member Author

We already have a lot of parameters in BenchmarkTask, it starts to look ugly. Maybe we can create another way to add new settings?

@mattwarren
Copy link
Contributor

We already have a lot of parameters in BenchmarkTask, it starts to look ugly.

Yeah that's a good point

Maybe we can create another way to add new settings?

I'm not sure what is a good way to do it though?

@AndreyAkinshin AndreyAkinshin added this to the v0.9.5 milestone Mar 24, 2016
@adamsitnik
Copy link
Member

I have just tried to rewrite LinqOptimizer project benchmarks to use BDN and failed because they were using <gcAllowVeryLargeObjects enabled="true" /> ;)

So there is a need for this feature ;)

@AndreyAkinshin AndreyAkinshin modified the milestones: v0.9.6, v0.9.5 Apr 20, 2016
@AndreyAkinshin AndreyAkinshin modified the milestones: v0.9.x, v0.9.6 May 7, 2016
@AndreyAkinshin
Copy link
Member Author

@adamsitnik, am I right that now we can close this issue?

@adamsitnik
Copy link
Member

@AndreyAkinshin gcAllowVeryLargeObjects is missing, I will add it right away

@adamsitnik adamsitnik self-assigned this Jun 15, 2016
@adamsitnik adamsitnik modified the milestones: v0.9.8, v0.9.x Jun 15, 2016
@adamsitnik adamsitnik changed the title Runtime Settings tuning Allow users to set gcAllowVeryLargeObjects for Runtime Settings Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants