Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail open vs fail closed #30

Open
oehlschl opened this issue May 7, 2019 · 0 comments
Open

fail open vs fail closed #30

oehlschl opened this issue May 7, 2019 · 0 comments

Comments

@oehlschl
Copy link
Contributor

oehlschl commented May 7, 2019

FYI, it looks like the Ruby enforcer will fail open (allow traffic through) in the case of an error with the library, here: https://github.com/goatapp/perimeterx-ruby-sdk/blob/209e1f757d41af744c4d5b41a7ad5a3fe55d9e2e/lib/perimeter_x.rb#L126-L126

I don't know how the other enforcers work, but given the likelihood of users tampering with input and the relative infrequency of change to this library, it may be worth having this logic fail closed to block the request. (Also dependent upon SLAs, etc.) If it should be up to the user, that may be an option as well.

How do the other enforcers work?

Also, because this is such a severe error (bypassing request scoring/blocking due to an unexpected error), it may be worth logging a queryable string in addition to the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant