Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: ProhibitCommaSeparatedStatements on anonymous hashref #590

Closed
Grinnz opened this issue Aug 27, 2014 · 3 comments
Closed

Comments

@Grinnz
Copy link
Contributor

Grinnz commented Aug 27, 2014

my %hash;
$hash{'asdf'} //= { 'a' => 1, 'b' => 2 };

generates: Comma used to separate statements at line 7, column 21. See pages 68,71 of PBP. (Severity: 4)

Perl::Critic version 1.122

@moregan
Copy link
Contributor

moregan commented Aug 28, 2014

This has the same sort of underlying cause in PPI as #390 and #192 . I have a PPI fix in the works.

@wchristian
Copy link
Member

The full version of the fix for this is now released to CPAN as PPI 1.220.

@thaljef
Copy link
Member

thaljef commented Nov 11, 2014

This is fixed in Perl-Critic-1.123 via PPI-1.220

@thaljef thaljef closed this as completed Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants