Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xt/40_criticize-code.t fails with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140 #911

Closed
ppisar opened this issue Jun 26, 2020 · 3 comments

Comments

@ppisar
Copy link

ppisar commented Jun 26, 2020

Perl-Critic-1.138 xt/40_criticize-code.t test fails with Perl 5.32.0:

$ prove -l xt/40_criticize-code.t 
xt/40_criticize-code.t .. 12/? 
#   Failed test 'Test::Perl::Critic for "blib/lib/Perl/Critic/Document.pm"'
#   at /usr/share/perl5/vendor_perl/Test/Perl/Critic.pm line 121.
# 
#   blib/lib/Perl/Critic/Document.pm: Subroutine name is a homonym for builtin function isa at line 140, column 1.  See page 177 of PBP.  (Severity: 4, Subroutines::ProhibitBuiltinHomonyms)
xt/40_criticize-code.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/198 subtests 

That's because Perl 5.32.0 added isa operator https://metacpan.org/pod/release/XSAWYERX/perl-5.32.0/pod/perldelta.pod#The-isa-Operator.

@ppisar ppisar changed the title xt/40_criticize-code.t fails with Perl 5.32: xt/40_criticize-code.t fails with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140 Jun 26, 2020
@h3xx
Copy link
Contributor

h3xx commented Sep 5, 2023

Looks like this was fixed in 7b57dcf.

@pghmcfc
Copy link

pghmcfc commented Sep 5, 2023

Indeed: the workaround I was using for this is no longer needed.

@petdance petdance closed this as completed Sep 7, 2023
@petdance
Copy link
Member

petdance commented Sep 7, 2023

Thanks for flagging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants