Remove eval around require Scalar::Util #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required version of perl is high enough that Scalar::Util should always be present. The eval is only needed because we are also checking the version. However, if Scalar::Util is broken for some reason, it's better to die than silence the error. If we silence the error, later attempts to load it will only give "Attepting to reload Scalar/Util.pm aborted", making diagnostics much harder.
karenetheridge
added a commit
that referenced
this pull request
Oct 8, 2014
Remove eval around require Scalar::Util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required version of perl is high enough that Scalar::Util should
always be present. The eval is only needed because we are also checking
the version. However, if Scalar::Util is broken for some reason, it's
better to die than silence the error. If we silence the error, later
attempts to load it will only give "Attempting to reload Scalar/Util.pm
aborted", making diagnostics much harder.