Skip to content

Commit

Permalink
t/op/sselect.t: skip 4 tests under miniperl
Browse files Browse the repository at this point in the history
Commit 85907e6 (July 22 2022) added unit tests to t/op/sselect.t but
failed to take into consideration that this file is run as part of 'make
minitest'.  When we run that command, we get this result:

    t/op/sselect .... FAILED--unexpected output at test 17

... which is due in part to a quirk in t/TEST.  To avoid this problem we
should SKIP the block of tests in question if we're running with
miniperl.

Remove nested 'SKIP:' block declaration; Not needed, per review by
@Leont.  Remove superfluous comma, spotted by @fgaspar.
  • Loading branch information
jkeenan committed Aug 7, 2022
1 parent 3c196ef commit 0f35d66
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions t/op/sselect.t
Expand Up @@ -106,6 +106,7 @@ select ($tie, undef, undef, $tie);
ok("no crash from select $numeric_tie, undef, undef, $numeric_tie");

SKIP: {
skip "Can't load modules under miniperl", 4 if is_miniperl;
my $SKIP_CR = sub {
skip shift, 4;
};
Expand Down

0 comments on commit 0f35d66

Please sign in to comment.