Skip to content

Commit

Permalink
version 07locale.t should use LC_NUMERIC, not ALL
Browse files Browse the repository at this point in the history
These outliers don't belong.  This file is working on LC_NUMERIC only.
  • Loading branch information
khwilliamson committed Nov 13, 2023
1 parent 5cb8110 commit 10c326a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions cpan/version/t/07locale.t
Expand Up @@ -50,7 +50,7 @@ SKIP: {

while (<DATA>) {
chomp;
$loc = setlocale( LC_ALL, $_);
$loc = setlocale( LC_NUMERIC, $_);
last if $loc && radix() eq ',';
}
skip 'Cannot test locale handling without a comma locale', 6
Expand All @@ -70,7 +70,7 @@ SKIP: {
$ver = 'version'->new($]);
is "$ver", "$]", 'Use PV for dualvars';
}
setlocale( LC_ALL, $orig_loc); # reset this before possible skip
setlocale( LC_NUMERIC, $orig_loc); # reset this before possible skip
skip 'Cannot test RT#46921 with Perl < 5.008', 1
if ($] < 5.008);
my ($fh, $filename) = tempfile('tXXXXXXX', SUFFIX => '.pm', UNLINK => 1);
Expand All @@ -81,10 +81,10 @@ use locale;
use POSIX qw(locale_h);
\$^W = 1;
use version;
setlocale (LC_ALL, '$loc');
setlocale (LC_NUMERIC, '$loc');
use version ;
eval "use Socket 1.7";
setlocale( LC_ALL, '$orig_loc');
setlocale( LC_NUMERIC, '$orig_loc');
1;
EOF
close $fh;
Expand Down
2 changes: 1 addition & 1 deletion t/porting/customized.dat
Expand Up @@ -22,4 +22,4 @@ Time::Piece cpan/Time-Piece/Piece.xs 543152540ee17788a638b2c5746b86c3d04401d1
Win32API::File cpan/Win32API-File/File.pm 8fd212857f821cb26648878b96e57f13bf21b99e
Win32API::File cpan/Win32API-File/File.xs beb870fed4490d2faa547b4a8576b8d64d1d27c5
version cpan/version/lib/version.pm a963b513cf812bd7f4d28b3422efd9904e70a34c
version cpan/version/t/07locale.t e3ee07d9f9159acb807a7fa29c712cc64f9b950b
version cpan/version/t/07locale.t 889f83b3efd52fed133d0a1483cade2bfa0ad6f1

0 comments on commit 10c326a

Please sign in to comment.