Perl_clear_defarray - revise ternary as per @hvds review

Perl · May 13, 2021 · 6c77e12 · 6c77e12
1 parent ff11f44
commit 6c77e12
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pp_hot.c b/pp_hot.c
@@ -4966,17 +4966,16 @@ PP(pp_leavesub)
 void
 Perl_clear_defarray(pTHX_ AV* av, bool abandon)
 {
-    const SSize_t fill = AvFILLp(av);
-
     PERL_ARGS_ASSERT_CLEAR_DEFARRAY;
 
     if (LIKELY(!abandon && SvREFCNT(av) == 1 && !SvMAGICAL(av))) {
         av_clear(av);
         AvREIFY_only(av);
     }
     else {
+        const SSize_t size = AvFILLp(av) + 1;
         /* fill can be -1. The ternary gives consistency with av_extend() */
-        AV *newav = newAV_alloc_xz(fill < 3 ? 4 : fill);
+        AV *newav = newAV_alloc_xz(size < 4 ? 4 : size);
         AvREIFY_only(newav);
         PAD_SVl(0) = MUTABLE_SV(newav);
         SvREFCNT_dec_NN(av);