Pod-Html: remove commented-out code

Make use of Exporter consistent.
Perl · Aug 23, 2021 · b2a21b5 · b2a21b5
1 parent b33902f
commit b2a21b5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/ext/Pod-Html/lib/Pod/Html.pm b/ext/Pod-Html/lib/Pod/Html.pm
@@ -24,7 +24,6 @@ use Pod::Html::Util qw(
     relativize_url
 );
 use locale; # make \w work right in non-ASCII lands
-use Data::Dumper;
 
 =head1 NAME
 
@@ -239,12 +238,6 @@ This program is distributed under the Artistic License.
 
 =cut
 
-
-my $Podroot;
-
-#my %Pages = ();                 # associative array used to find the location
-                                #   of pages referenced by L<> links.
-
 sub new {
     my $class = shift;
     return bless {}, $class;
@@ -380,12 +373,10 @@ sub refine_globals {
         # Is the above not just "$self->{Htmlfileurl} = $self->{Htmlfile}"?
         $self->{Htmlfileurl} = unixify($self->{Htmlfile});
     }
-    #return $self;
     return { %{$self} };
 }
 
 sub generate_cache {
-    #my ($self, $Pagesref) = @_;
     my $self = shift;
     my $pwd = getcwd();
     chdir($self->{Podroot}) ||
@@ -427,7 +418,6 @@ sub generate_cache {
         print $cache "$key $self->{Pages}->{$key}\n";
     }
     close $cache or die "error closing $self->{Dircache}: $!";
-    #return %{$Pagesref};
 }
 
 sub _transform {

diff --git a/ext/Pod-Html/lib/Pod/Html/Util.pm b/ext/Pod-Html/lib/Pod/Html/Util.pm
@@ -1,10 +1,9 @@
 package Pod::Html::Util;
 use strict;
-require Exporter;
+use Exporter 'import';
 
 our $VERSION = 1.33; # Please keep in synch with lib/Pod/Html.pm
 $VERSION = eval $VERSION;
-our @ISA = qw(Exporter);
 our @EXPORT_OK = qw(
     anchorify
     html_escape

diff --git a/ext/Pod-Html/t/lib/Testing.pm b/ext/Pod-Html/t/lib/Testing.pm
@@ -1,10 +1,9 @@
 package Testing;
 use 5.10.0;
 use warnings;
-require Exporter;
+use Exporter 'import';
 our $VERSION = 1.33; # Let's keep this same as lib/Pod/Html.pm
 $VERSION = eval $VERSION;
-our @ISA = qw(Exporter);
 our @EXPORT_OK = qw(
     setup_testing_dir
     xconvert