Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Update ExtUtils::CBuilder to CPAN version #14064

Closed
p5pRT opened this issue Sep 1, 2014 · 15 comments

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Sep 1, 2014

Migrated from rt.perl.org#122675 (status was 'resolved')

Searchable as RT122675$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

Created by ambs@cpan.org

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

Cheers
ambs

Perl Info

Flags:
    category=library
    severity=low
    Type=Patch
    PatchStatus=HasPatch
    module=ExtUtils::CBuilder

Site configuration information for perl 5.20.0:

Configured by root at Wed Aug 20 14:19:28 WEST 2014.

Summary of my perl5 (revision 5 version 20 subversion 0) configuration:
   
  Platform:
    osname=linux, osvers=3.10.17, archname=i686-linux
    uname='linux eremita 3.10.17 #2 wed oct 23 17:46:52 cdt 2013 i686 intel(r) core(tm)2 duo cpu e7500 @ 2.93ghz genuineintel gnulinux '
    config_args='-ds -e -Dprefix=/opt/perl-5.20.0'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.8.2', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/i486-slackware-linux/4.8.2/include-fixed /usr/lib /lib
    libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.17'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'



@INC for perl 5.20.0:
    /opt/perl-5.20.0/lib/site_perl/5.20.0/i686-linux
    /opt/perl-5.20.0/lib/site_perl/5.20.0
    /opt/perl-5.20.0/lib/5.20.0/i686-linux
    /opt/perl-5.20.0/lib/5.20.0
    .


Environment for perl 5.20.0:
    HOME=/home/ambs
    LANG=en_US
    LANGUAGE (unset)
    LC_COLLATE=C
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/local/bin:/usr/bin:/bin:/usr/games:/usr/lib/qt/bin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

EUCB.patch
diff --git a/dist/ExtUtils-CBuilder/Changes b/dist/ExtUtils-CBuilder/Changes
index 5c03667..57fc79f 100644
--- a/dist/ExtUtils-CBuilder/Changes
+++ b/dist/ExtUtils-CBuilder/Changes
@@ -1,5 +1,11 @@
 Revision history for Perl extension ExtUtils::CBuilder.
 
+0.280217 - 2014-08-22
+
+  Fixed:
+
+  - Quoted perl path for Windows support #98245 [Alberto Sim��es] 
+
 0.280216 - 2014-03-07
 
   Added:
diff --git a/dist/ExtUtils-CBuilder/t/00-have-compiler.t b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
index ffb1b04..1661812 100644
--- a/dist/ExtUtils-CBuilder/t/00-have-compiler.t
+++ b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
@@ -4,6 +4,7 @@ use File::Spec;
 my $perl;
 BEGIN {
   $perl = File::Spec->rel2abs($^X);
+  $perl = qq{"$perl"}; # So it doesn't fail when there are spaces.
 }
 
 use strict;
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From @jkeenan

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

Cheers
ambs

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags​:
category=library
severity=low
Type=Patch
PatchStatus=HasPatch
module=ExtUtils​::CBuilder
---
Site configuration information for perl 5.20.0​:

Configured by root at Wed Aug 20 14​:19​:28 WEST 2014.

Summary of my perl5 (revision 5 version 20 subversion 0)
configuration​:

Platform​:
osname=linux, osvers=3.10.17, archname=i686-linux
uname='linux eremita 3.10.17 #2 wed oct 23 17​:46​:52 cdt 2013 i686
intel(r) core(tm)2 duo cpu e7500 @​ 2.93ghz genuineintel gnulinux '
config_args='-ds -e -Dprefix=/opt/perl-5.20.0'
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
use64bitint=undef, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler​:
cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-
protector -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64',
optimize='-O2',
cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
ccversion='', gccversion='4.8.2', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
alignbytes=4, prototype=define
Linker and Libraries​:
ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/i486-slackware-
linux/4.8.2/include-fixed /usr/lib /lib
libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.17'
Dynamic Linking​:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-
protector'

---
@​INC for perl 5.20.0​:
/opt/perl-5.20.0/lib/site_perl/5.20.0/i686-linux
/opt/perl-5.20.0/lib/site_perl/5.20.0
/opt/perl-5.20.0/lib/5.20.0/i686-linux
/opt/perl-5.20.0/lib/5.20.0
.

---
Environment for perl 5.20.0​:
HOME=/home/ambs
LANG=en_US
LANGUAGE (unset)
LC_COLLATE=C
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/games​:/usr/lib/qt/bin
PERL_BADLANG (unset)
SHELL=/bin/bash

ambs​:

Thank you for the patch. When I went to apply it, however, I noticed that it updated only one test file and Changes. It did not update Makefile.PL, which is where VERSION is declared in this distribution. Since we have the Makefile.PL in core, shouldn't we update VERSION there as well?

Would it be possible to re-draw the patch to include changes to Makefile.PL?

Thank you very much.
Jim Keenan

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

Cheers
ambs

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags​:
category=library
severity=low
Type=Patch
PatchStatus=HasPatch
module=ExtUtils​::CBuilder
---
Site configuration information for perl 5.20.0​:

Configured by root at Wed Aug 20 14​:19​:28 WEST 2014.

Summary of my perl5 (revision 5 version 20 subversion 0)
configuration​:

Platform​:
osname=linux, osvers=3.10.17, archname=i686-linux
uname='linux eremita 3.10.17 #2 wed oct 23 17​:46​:52 cdt 2013 i686
intel(r) core(tm)2 duo cpu e7500 @​ 2.93ghz genuineintel gnulinux '
config_args='-ds -e -Dprefix=/opt/perl-5.20.0'
hint=recommended, useposix=true, d_sigaction=define
useithreads=undef, usemultiplicity=undef
use64bitint=undef, use64bitall=undef, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler​:
cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-
protector -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64',
optimize='-O2',
cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
ccversion='', gccversion='4.8.2', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
alignbytes=4, prototype=define
Linker and Libraries​:
ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/i486-slackware-
linux/4.8.2/include-fixed /usr/lib /lib
libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.17'
Dynamic Linking​:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-
protector'

---
@​INC for perl 5.20.0​:
/opt/perl-5.20.0/lib/site_perl/5.20.0/i686-linux
/opt/perl-5.20.0/lib/site_perl/5.20.0
/opt/perl-5.20.0/lib/5.20.0/i686-linux
/opt/perl-5.20.0/lib/5.20.0
.

---
Environment for perl 5.20.0​:
HOME=/home/ambs
LANG=en_US
LANGUAGE (unset)
LC_COLLATE=C
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/games​:/usr/lib/qt/bin
PERL_BADLANG (unset)
SHELL=/bin/bash

ambs​:

Thank you for the patch. When I went to apply it, however, I noticed that it updated only one test file and Changes. It did not update Makefile.PL, which is where VERSION is declared in this distribution. Since we have the Makefile.PL in core, shouldn't we update VERSION there as well?

Would it be possible to re-draw the patch to include changes to Makefile.PL?

Thank you very much.
Jim Keenan

Please check if this one is better.

It changes a lot more files, given that I am using dzil to generate
versions on all modules.

If by some reason this is not good for the core, let me know, and I'll
revert my changes.

Thanks
ambs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

CBuilder.patch
diff --git a/dist/ExtUtils-CBuilder/Changes b/dist/ExtUtils-CBuilder/Changes
index 5c03667..07c305d 100644
--- a/dist/ExtUtils-CBuilder/Changes
+++ b/dist/ExtUtils-CBuilder/Changes
@@ -1,5 +1,18 @@
 Revision history for Perl extension ExtUtils::CBuilder.
 
+0.280218 - 2014-09-01
+
+  Fixed:
+
+  - Mispelled 'starup' key in BCC support was fixed. #79574
+  - Fixed the version in the PM file (thanks to Jim Keenan)
+
+0.280217 - 2014-08-22
+
+  Fixed:
+
+  - Quoted perl path for Windows support #98245 [Alberto Simões] 
+
 0.280216 - 2014-03-07
 
   Added:
diff --git a/dist/ExtUtils-CBuilder/Makefile.PL b/dist/ExtUtils-CBuilder/Makefile.PL
index fb429cd..dd59c8e 100644
--- a/dist/ExtUtils-CBuilder/Makefile.PL
+++ b/dist/ExtUtils-CBuilder/Makefile.PL
@@ -34,7 +34,7 @@ my %WriteMakefileArgs = (
   "TEST_REQUIRES" => {
     "Test::More" => "0.47"
   },
-  "VERSION" => "0.280216",
+  "VERSION_FROM" => "lib/ExtUtils/CBuilder.pm",
   "test" => {
     "TESTS" => "t/*.t"
   }
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
index 98a68a0..2ae89a8 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
@@ -1,13 +1,11 @@
 package ExtUtils::CBuilder;
-
+$ExtUtils::CBuilder::VERSION = '0.280218';
 use File::Spec ();
 use File::Path ();
 use File::Basename ();
 use Perl::OSType qw/os_type/;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
-$VERSION = eval $VERSION;
+use vars qw(@ISA);
 
 # We only use this once - don't waste a symbol table entry on it.
 # More importantly, don't make it an inheritable method.
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
index 4392b7f..fb7d85b 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
@@ -1,5 +1,5 @@
 package ExtUtils::CBuilder::Base;
-
+$ExtUtils::CBuilder::Base::VERSION = '0.280218';
 use strict;
 use File::Spec;
 use File::Basename;
@@ -9,9 +9,6 @@ use Text::ParseWords;
 use IPC::Cmd qw(can_run);
 use File::Temp qw(tempfile);
 
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
 # More details about C/C++ compilers:
 # http://developers.sun.com/sunstudio/documentation/product/compiler.jsp
 # http://gcc.gnu.org/
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
index d948bbf..bf24a53 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::Unix;
-
+$ExtUtils::CBuilder::Platform::Unix::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Base;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 sub link_executable {
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
index d296bab..e362114 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::VMS;
-
+$ExtUtils::CBuilder::Platform::VMS::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Base;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 use File::Spec::Functions qw(catfile catdir);
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
index f9e4070..d25891d 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
@@ -1,5 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows;
-
+$ExtUtils::CBuilder::Platform::Windows::VERSION = '0.280218';
 use strict;
 use warnings;
 
@@ -9,8 +9,7 @@ use File::Spec;
 use ExtUtils::CBuilder::Base;
 use IO::File;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 =begin comment
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
index aab1437..072d1fd 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::BCC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::BCC::VERSION = '0.280218';
 sub format_compiler_cmd {
   my ($self, %spec) = @_;
 
@@ -64,7 +61,7 @@ sub format_linker_cmd {
   }
 
   push( @{$spec{startup}}, 'c0d32.obj' )
-    unless ( $spec{starup} && @{$spec{startup}} );
+    unless ( $spec{startup} && @{$spec{startup}} );
 
   %spec = $self->write_linker_script(%spec)
     if $spec{use_scripts};
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
index b8a32a8..1dd5d20 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::GCC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::GCC::VERSION = '0.280218';
 sub format_compiler_cmd {
   my ($self, %spec) = @_;
 
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
index 3d4b5ab..289af72 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::MSVC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::MSVC::VERSION = '0.280218';
 sub arg_exec_file {
   my ($self, $file) = @_;
   return "/OUT:$file";
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
index ecc14f8..c3ffc22 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
@@ -1,11 +1,10 @@
 package ExtUtils::CBuilder::Platform::aix;
-
+$ExtUtils::CBuilder::Platform::aix::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 use File::Spec;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub need_prelink { 1 }
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
index e2be516..a0ad617 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
@@ -1,12 +1,10 @@
 package ExtUtils::CBuilder::Platform::android;
-
+$ExtUtils::CBuilder::Platform::android::VERSION = '0.280218';
 use strict;
-use Config;
 use File::Spec;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 # The Android linker will not recognize symbols from
@@ -19,7 +17,6 @@ sub link {
       $self->split_like_shell($args{extra_linker_flags}),
       '-L' . $self->perl_inc(),
       '-lperl',
-      $self->split_like_shell($Config{perllibs}),
     ];
   }
 
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
index 43e6a47..97c8297 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
@@ -1,11 +1,10 @@
 package ExtUtils::CBuilder::Platform::cygwin;
-
+$ExtUtils::CBuilder::Platform::cygwin::VERSION = '0.280218';
 use strict;
 use File::Spec;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 # TODO: If a specific exe_file name is requested, if the exe created
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
index bc4f188..7205d1b 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::darwin;
-
+$ExtUtils::CBuilder::Platform::darwin::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub compile {
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
index f16fc01..eaa8adf 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
@@ -1,12 +1,11 @@
 package ExtUtils::CBuilder::Platform::dec_osf;
-
+$ExtUtils::CBuilder::Platform::dec_osf::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 use File::Spec;
 
-use vars qw($VERSION @ISA);
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
-$VERSION = '0.280217';
 
 sub link_executable {
   my $self = shift;
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
index 3d4867c..9960368 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::os2;
-
+$ExtUtils::CBuilder::Platform::os2::VERSION = '0.280218';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub need_prelink { 1 }
diff --git a/dist/ExtUtils-CBuilder/t/00-have-compiler.t b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
index ffb1b04..1661812 100644
--- a/dist/ExtUtils-CBuilder/t/00-have-compiler.t
+++ b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
@@ -4,6 +4,7 @@ use File::Spec;
 my $perl;
 BEGIN {
   $perl = File::Spec->rel2abs($^X);
+  $perl = qq{"$perl"}; # So it doesn't fail when there are spaces.
 }
 
 use strict;
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From @Hugmeir

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

Hello

On 01/09/14, 15​:13, Brian Fraser wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

Erm, not really. I tried to see if there were changes.
I looked again to the patch and I see what you mean.
I'll merge it, prepare a new release, and send a new patch.

Thanks for the notice!

ambs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

On 01/09/14, 15​:18, Alberto Simões wrote​:

Hello

On 01/09/14, 15​:13, Brian Fraser wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

I think I fixed it now.

Thanks, one more time.

ambs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

CBuilder.patch
diff --git a/dist/ExtUtils-CBuilder/Changes b/dist/ExtUtils-CBuilder/Changes
index 5c03667..8c5ab45 100644
--- a/dist/ExtUtils-CBuilder/Changes
+++ b/dist/ExtUtils-CBuilder/Changes
@@ -1,5 +1,24 @@
 Revision history for Perl extension ExtUtils::CBuilder.
 
+0.280219 - 2014-09-01
+
+  Fixed:
+
+  - Fixed regression on Android (thanks to Brian Fraser)
+
+0.280218 - 2014-09-01
+
+  Fixed:
+
+  - Mispelled 'starup' key in BCC support was fixed. #79574
+  - Fixed the version in the PM file (thanks to Jim Keenan)
+
+0.280217 - 2014-08-22
+
+  Fixed:
+
+  - Quoted perl path for Windows support #98245 [Alberto Simões] 
+
 0.280216 - 2014-03-07
 
   Added:
diff --git a/dist/ExtUtils-CBuilder/Makefile.PL b/dist/ExtUtils-CBuilder/Makefile.PL
index fb429cd..dd59c8e 100644
--- a/dist/ExtUtils-CBuilder/Makefile.PL
+++ b/dist/ExtUtils-CBuilder/Makefile.PL
@@ -34,7 +34,7 @@ my %WriteMakefileArgs = (
   "TEST_REQUIRES" => {
     "Test::More" => "0.47"
   },
-  "VERSION" => "0.280216",
+  "VERSION_FROM" => "lib/ExtUtils/CBuilder.pm",
   "test" => {
     "TESTS" => "t/*.t"
   }
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
index 98a68a0..43de8a9 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
@@ -1,13 +1,11 @@
 package ExtUtils::CBuilder;
-
+$ExtUtils::CBuilder::VERSION = '0.280219';
 use File::Spec ();
 use File::Path ();
 use File::Basename ();
 use Perl::OSType qw/os_type/;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
-$VERSION = eval $VERSION;
+use vars qw(@ISA);
 
 # We only use this once - don't waste a symbol table entry on it.
 # More importantly, don't make it an inheritable method.
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
index 4392b7f..d52b705 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
@@ -1,5 +1,5 @@
 package ExtUtils::CBuilder::Base;
-
+$ExtUtils::CBuilder::Base::VERSION = '0.280219';
 use strict;
 use File::Spec;
 use File::Basename;
@@ -9,9 +9,6 @@ use Text::ParseWords;
 use IPC::Cmd qw(can_run);
 use File::Temp qw(tempfile);
 
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
 # More details about C/C++ compilers:
 # http://developers.sun.com/sunstudio/documentation/product/compiler.jsp
 # http://gcc.gnu.org/
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
index d948bbf..fcc0d73 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Unix.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::Unix;
-
+$ExtUtils::CBuilder::Platform::Unix::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Base;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 sub link_executable {
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
index d296bab..fc8f9e4 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/VMS.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::VMS;
-
+$ExtUtils::CBuilder::Platform::VMS::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Base;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 use File::Spec::Functions qw(catfile catdir);
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
index f9e4070..e8ad286 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
@@ -1,5 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows;
-
+$ExtUtils::CBuilder::Platform::Windows::VERSION = '0.280219';
 use strict;
 use warnings;
 
@@ -9,8 +9,7 @@ use File::Spec;
 use ExtUtils::CBuilder::Base;
 use IO::File;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Base);
 
 =begin comment
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
index aab1437..2a18cdb 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/BCC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::BCC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::BCC::VERSION = '0.280219';
 sub format_compiler_cmd {
   my ($self, %spec) = @_;
 
@@ -64,7 +61,7 @@ sub format_linker_cmd {
   }
 
   push( @{$spec{startup}}, 'c0d32.obj' )
-    unless ( $spec{starup} && @{$spec{startup}} );
+    unless ( $spec{startup} && @{$spec{startup}} );
 
   %spec = $self->write_linker_script(%spec)
     if $spec{use_scripts};
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
index b8a32a8..b45cada 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/GCC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::GCC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::GCC::VERSION = '0.280219';
 sub format_compiler_cmd {
   my ($self, %spec) = @_;
 
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
index 3d4b5ab..170b057 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows/MSVC.pm
@@ -1,8 +1,5 @@
 package ExtUtils::CBuilder::Platform::Windows::MSVC;
-
-use vars qw($VERSION);
-$VERSION = '0.280217';
-
+$ExtUtils::CBuilder::Platform::Windows::MSVC::VERSION = '0.280219';
 sub arg_exec_file {
   my ($self, $file) = @_;
   return "/OUT:$file";
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
index ecc14f8..e9904a1 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/aix.pm
@@ -1,11 +1,10 @@
 package ExtUtils::CBuilder::Platform::aix;
-
+$ExtUtils::CBuilder::Platform::aix::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 use File::Spec;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub need_prelink { 1 }
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
index e2be516..d0b2180 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/android.pm
@@ -1,12 +1,10 @@
 package ExtUtils::CBuilder::Platform::android;
-
+$ExtUtils::CBuilder::Platform::android::VERSION = '0.280219';
 use strict;
-use Config;
 use File::Spec;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 # The Android linker will not recognize symbols from
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
index 43e6a47..10a2e9c 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/cygwin.pm
@@ -1,11 +1,10 @@
 package ExtUtils::CBuilder::Platform::cygwin;
-
+$ExtUtils::CBuilder::Platform::cygwin::VERSION = '0.280219';
 use strict;
 use File::Spec;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 # TODO: If a specific exe_file name is requested, if the exe created
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
index bc4f188..9969a8a 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/darwin.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::darwin;
-
+$ExtUtils::CBuilder::Platform::darwin::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub compile {
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
index f16fc01..95e2905 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/dec_osf.pm
@@ -1,12 +1,11 @@
 package ExtUtils::CBuilder::Platform::dec_osf;
-
+$ExtUtils::CBuilder::Platform::dec_osf::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 use File::Spec;
 
-use vars qw($VERSION @ISA);
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
-$VERSION = '0.280217';
 
 sub link_executable {
   my $self = shift;
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
index 3d4867c..0d46aeb 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/os2.pm
@@ -1,10 +1,9 @@
 package ExtUtils::CBuilder::Platform::os2;
-
+$ExtUtils::CBuilder::Platform::os2::VERSION = '0.280219';
 use strict;
 use ExtUtils::CBuilder::Platform::Unix;
 
-use vars qw($VERSION @ISA);
-$VERSION = '0.280217';
+use vars qw(@ISA);
 @ISA = qw(ExtUtils::CBuilder::Platform::Unix);
 
 sub need_prelink { 1 }
diff --git a/dist/ExtUtils-CBuilder/t/00-have-compiler.t b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
index ffb1b04..1661812 100644
--- a/dist/ExtUtils-CBuilder/t/00-have-compiler.t
+++ b/dist/ExtUtils-CBuilder/t/00-have-compiler.t
@@ -4,6 +4,7 @@ use File::Spec;
 my $perl;
 BEGIN {
   $perl = File::Spec->rel2abs($^X);
+  $perl = qq{"$perl"}; # So it doesn't fail when there are spaces.
 }
 
 use strict;
@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From @jkeenan

On Mon Sep 01 07​:14​:01 2014, Hugmeir wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

Good point. ExtUtils-CBuilder is currently located under dist/. According to pod/perlsource.pod,

#####
[dist/] is for dual-life modules where the blead source is canonical. ... Modules under F<dist/> should make an effort to work with earlier versions of Perl 5.
#####

We could move it to cpan/, where the CPAN version is canonical -- BUT that should be the subject of a DIFFERENT RT ticket.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From ambs@zbr.pt

On 01/09/14, 19​:31, James E Keenan via RT wrote​:

On Mon Sep 01 07​:14​:01 2014, Hugmeir wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

Good point. ExtUtils-CBuilder is currently located under dist/. According to pod/perlsource.pod,

#####
[dist/] is for dual-life modules where the blead source is canonical. ... Modules under F<dist/> should make an effort to work with earlier versions of Perl 5.
#####

We could move it to cpan/, where the CPAN version is canonical -- BUT that should be the subject of a DIFFERENT RT ticket.

Happy to keep it as it is.
It was a mistake.

Best
ambs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 1, 2014

From @jkeenan

On Mon Sep 01 07​:27​:44 2014, ambs wrote​:

On 01/09/14, 15​:18, Alberto Simões wrote​:

Hello

On 01/09/14, 15​:13, Brian Fraser wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB version.

The patch undoes one of the fixes for Android that I pushed to bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

I think I fixed it now.

Thanks, one more time.

ambs

I applied the patch to blead in commit 74d5bfa

hugmeir​: I checked to make sure that your most recent commit to the android module is included, but feel free to double-check.

I'll close this ticket within 7 days unless there are further complaints.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 6, 2014

From @jkeenan

On Mon Sep 01 11​:40​:46 2014, jkeenan wrote​:

On Mon Sep 01 07​:27​:44 2014, ambs wrote​:

On 01/09/14, 15​:18, Alberto Simões wrote​:

Hello

On 01/09/14, 15​:13, Brian Fraser wrote​:

On Mon, Sep 1, 2014 at 3​:45 PM, Alberto Simões
<albie@​alfarrabio.di.uminho.pt> wrote​:

On 01/09/14, 13​:25, James E Keenan via RT wrote​:

On Mon Sep 01 03​:46​:05 2014, ambs@​cpan.org wrote​:

This is a bug report for perl from ambs@​cpan.org,
generated with the help of perlbug 1.40 running under perl
5.20.0.

-----------------------------------------------------------------
[Please describe your issue here]

A fix was included in EU​::CBuilder, and a version released to
CPAN. The attached patch updates perl tree to latest EU​::CB
version.

The patch undoes one of the fixes for Android that I pushed to
bleed
some weeks back; is CPAN now the correct upstream for EU​::CB?

I think I fixed it now.

Thanks, one more time.

ambs

I applied the patch to blead in commit
74d5bfa

hugmeir​: I checked to make sure that your most recent commit to the
android module is included, but feel free to double-check.

I'll close this ticket within 7 days unless there are further
complaints.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Sep 6, 2014

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.