BBC: HIO/ExtUtils-MY_Metafile-0.09.tar.gz fails since perl 5.31.9

[eserte]

Output of test failure:

#   Failed test '[default] eval: Attempt to reload inc/ExtUtils/MY_Metafile.pm aborted.
# Compilation failed in require at (eval 14) line 1.
# BEGIN failed--compilation aborted at (eval 14) line 1.
# '
#   at t/01_inc_import.t line 36.
# Looks like you failed 1 test of 2.
t/01_inc_import.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

http://fast-matrix.cpantesters.org/?dist=ExtUtils-MY_Metafile%200.09 shows that the failure started with perl 5.31.9.

[Leont]

That sounds like the recent change in meaning of undef in %INC @tonycoz

[jkeenan]

Output of test failure:

#   Failed test '[default] eval: Attempt to reload inc/ExtUtils/MY_Metafile.pm aborted.
# Compilation failed in require at (eval 14) line 1.
# BEGIN failed--compilation aborted at (eval 14) line 1.
# '
#   at t/01_inc_import.t line 36.
# Looks like you failed 1 test of 2.
t/01_inc_import.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

http://fast-matrix.cpantesters.org/?dist=ExtUtils-MY_Metafile%200.09 shows that the failure started with perl 5.31.9.

Confirming Leon's hunch, bisection points to:

commit 4b004c43ef26ce175181122a7dfc3acd7dacb170
Author:     Tony Cook <tony@develop-help.com>
AuthorDate: Tue Jan 21 16:12:44 2020 +1100
Commit:     Tony Cook <tony@develop-help.com>
CommitDate: Mon Jan 27 10:23:08 2020 +1100

    always treat undef in %INC as a failed require
    
    Previously require would check for the specific \&PL_sv_undef
    SV in %INC, this meant that if %INC was copied, or undef
    assigned to a member the entry would erroneously be treated as if
    a previous require of that file was successful.
    
    So check for SvOK() instead, with appropriate magic tests.
    
    fixes #17428

I suspect that this is a case where we'll rule in favor of blead, but ...
Tony, can you take a look?

Thank you very much.
Jim Keenan

[jkeenan]

I have submitted a patch upstream to correct the test failure.

@tonycoz Is this ticket now closable?

[tonycoz]

Yes, I think so.

The change means the undef that test code assigns is now (reasonably) treated as having failed to load the module, rather than as having successfully loaded the module.

Closed.