Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpan/IO-Compress/bin/zipdetails does not build warning free with 32 bit integers, fails utils tests #19617

Closed
demerphq opened this issue Apr 12, 2022 · 1 comment

Comments

@demerphq
Copy link
Collaborator

demerphq commented Apr 12, 2022

Module:
IO-Compress 2.105

Description
IO-Compress 2.105 (and maybe earlier I havent checked) fails porting/utils.t on 32 integer builds.

# Failed test 83 - utils/zipdetails compiles at porting/utils.t line 85
#      got "Integer overflow in hexadecimal number at utils/zipdetails line 1432.
Integer overflow in hexadecimal number at utils/zipdetails line 2247.
Integer overflow in hexadecimal number at utils/zipdetails line 2248.
Integer overflow in hexadecimal number at utils/zipdetails line 2249.
Integer overflow in hexadecimal number at utils/zipdetails line 2250.
Integer overflow in hexadecimal number at utils/zipdetails line 2251.
Integer overflow in hexadecimal number at utils/zipdetails line 2252.
Integer overflow in hexadecimal number at utils/zipdetails line 2253.
Integer overflow in hexadecimal number at utils/zipdetails line 2254.
utils/zipdetails syntax OK
"
# expected "utils/zipdetails syntax OK
"
t/porting/utils .................................................. FAILED at test 83

As can be seen here: https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true

Note that this showed up in #19611 but is unrelated to the change in that PR.

See also:
pmqs/zipdetails#8
pmqs/zipdetails#7
#19618
pmqs/IO-Compress#45

Steps to Reproduce
Build a perl on i386, run tests. Or just eyeball zipdetails which contains 64 bit hex constants.

Expected behavior
No warnings.

Perl configuration
Blead perl on i386 32 bit integers as of 66f51c8

LD_LIBRARY_PATH=`pwd` ./perl -Ilib -V
Summary of my perl5 (revision 5 version 35 subversion 11) configuration:
  Commit id: 772423b7fabbeabdb6623d[8](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:8)fca3a336a533f77a5
  Platform:
    osname=linux
    osvers=5.13.0-1021-azure
    archname=x86_64-linux
    uname='linux c[9](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:9)bc1b079f7d 5.13.0-[10](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:10)21-azure #24~20.04.1-ubuntu smp tue mar 29 15:34:22 utc 2022 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dusedevel -Dusedevel -Dprefix=/github/home/perl-blead'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=undef
    use64bitall=undef
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='7.5.0'
    gccosandvers=''
    intsize=4
    longsize=4
    ptrsize=4
    doublesize=8
    byteorder=1234
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=12
    longdblkind=3
    ivtype='long'
    ivsize=4
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=4
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/i386-linux-gnu /usr/lib /lib/i386-linux-gnu /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.27.so
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.27'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_TIMES
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_DEVEL
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
  Built under linux
  Compiled at Apr [11](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:11) 2022 [16](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:16):[28](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:28):43
  %ENV:
    PERL_SKIP_TTY_TEST="1"
  @INC:
    lib
    /github/home/perl-blead/lib/site_perl/5.[35](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:35).11/x86_[64](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:64)-linux
    /github/home/perl-blead/lib/site_perl/5.35.11
    /github/home/perl-blead/lib/5.35.11/x[86](https://github.com/Perl/perl5/runs/5976111262?check_suite_focus=true#step:9:86)_64-linux
    /github/home/perl-blead/lib/5.35.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant