Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announce 5.42 removal of goto to jump into construct #21601

Merged
merged 1 commit into from Nov 5, 2023
Merged

Announce 5.42 removal of goto to jump into construct #21601

merged 1 commit into from Nov 5, 2023

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Oct 28, 2023

Fixes #16275

hvds
hvds approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@hvds hvds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked if there are other docs that need updating.

pod/perlfunc.pod Outdated Show resolved Hide resolved
jkeenan added a commit that referenced this pull request Oct 28, 2023
@jkeenan
perlfunc: clarify documentation
330341d 
Per suggestion from Hugo van der Sanden in
#21601.
@jkeenan jkeenan added documentation squash-before-merge Author must squash the commits down before merging to blead labels Oct 28, 2023
@jkeenan
Copy link
Contributor Author

jkeenan commented Oct 28, 2023

I have not checked if there are other docs that need updating.

What would be helpful is if you could review the documentation of goto in pod/perlfunc.pod (e.g., https://github.com/Perl/perl5/blob/blead/pod/perlfunc.pod#goto-LABEL) to see if there's anything else that would be affected by this change. I myself don't think there is, but then again I've never written goto in Perl code.

@jkeenan jkeenan self-assigned this Oct 30, 2023
@hvds
Copy link
Contributor

hvds commented Oct 30, 2023

What would be helpful is if you could review the documentation of goto in pod/perlfunc.pod to see if there's anything else that would be affected by this change.

I don't see anything else there that would be affected.

@jkeenan
Copy link
Contributor Author

jkeenan commented Oct 30, 2023

Fixes #16275

@leonerd can you check to see if this p.r. is satisfactory? Thanks.

@jkeenan
Announce 5.42 removal of goto to jump into construct
bf38025 
perlfunc: clarify documentation per suggestion from Hugo van der Sanden in
#21601.

Fixes #16275
@jkeenan jkeenan force-pushed the smoke-me/jkeenan/fatal-goto-20231027-gh-16275 branch from 330341d to bf38025 Compare November 5, 2023 20:07
@jkeenan jkeenan removed the squash-before-merge Author must squash the commits down before merging to blead label Nov 5, 2023
@jkeenan jkeenan merged commit a23e475 into blead Nov 5, 2023
57 checks passed
@jkeenan jkeenan deleted the smoke-me/jkeenan/fatal-goto-20231027-gh-16275 branch November 5, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvds hvds hvds approved these changes

@rwp0 rwp0 rwp0 approved these changes

@demerphq demerphq Awaiting requested review from demerphq

@leonerd leonerd Awaiting requested review from leonerd

Assignees

@jkeenan jkeenan

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inward goto deprecation has no removal date
3 participants
@jkeenan @hvds @rwp0