Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better diagnostic when filter excludes all #380

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

plicease
Copy link
Member

@plicease plicease commented Oct 26, 2022

Caveat: the filter stage should not modify the $res passed in, but that doesn't actually stop it from doing that :/

before:

Alien::Build::Plugin::Core::Download> decoding html
no matching files in listing at /home/ollisg/opt/perl/5.37.5/lib/site_perl/5.37.5/Alien/Build/Plugin/Core/Download.pm line 61.
Recipe did not seem to download a file or directory

after:

Alien::Build::Plugin::Core::Download> decoding html
Alien::Build::Plugin::Core::Download> These files were excluded by the filter stage:
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/?C=N;O=D
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/?C=M;O=A
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/?C=S;O=A
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/?C=D;O=A
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/README.older-versions
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.75-3.76.diff.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.75.tar.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.76-3.76.1.diff.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.76.1-3.77.diff.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.76.1.tar.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.77.tar.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.78.1.tar.gz
Alien::Build::Plugin::Core::Download> excluded https://ftp.gnu.org/gnu/make/make-3.79.1.tar.gz
Alien::Build::Plugin::Core::Download> excluded ...
no matching files in listing at /home/ollisg/opt/perl/5.37.5/lib/site_perl/5.37.5/Alien/Build/Plugin/Core/Download.pm line 61.
Recipe did not seem to download a file or directory

@plicease plicease merged commit 6c14992 into main Oct 26, 2022
@plicease plicease deleted the graham/improved-diagnostic-when-filter-removes-all branch October 26, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant