Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout not reset if unhandled error thrown in route code. #1

Open
wassupduck opened this issue Jul 10, 2015 · 1 comment
Open

Layout not reset if unhandled error thrown in route code. #1

wassupduck opened this issue Jul 10, 2015 · 1 comment

Comments

@wassupduck
Copy link

When an error is thrown in the route code and is not handled the layout is never reset.

Scenario:

  1. Add ajax route that dies to an existing Dancer2 app that uses a layout.
  2. Navigate around app from browser - layout and content rendered.
  3. Send ajax request to erroneous ajax route.
  4. Navigate around app from browser - content will be rendered, layout will not.

Example erroneous ajax route:

ajax '/error' => sub {
  die 'houston we have a problem!';
};
@konsumate
Copy link

konsumate commented Mar 5, 2017

I've tried a fix in #4 - please review or enhance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants