Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logged_in_user_password_expired keyword #26

Merged
merged 3 commits into from May 1, 2015

Conversation

abeverley
Copy link
Collaborator

This adds functionality to help manage the expiry of passwords. It requires appropriate support from the relevant provider. See ctrlo/Dancer2-Plugin-Auth-Extensible-Provider-DBIC@018eca3 for an example.

Andrew Beverley added 2 commits April 29, 2015 11:29
This adds functionality to help manage the expiry of passwords. It
requires appropriate support from the relevant provider.
@racke
Copy link
Member

racke commented May 1, 2015

What is the intended workflow? I suppose you want to force these users to change their password, right? In this case you need to prevent that they get access to protected routes.

@abeverley
Copy link
Collaborator Author

My intention was that it's up to the developer how to do the actual implemention: in my case, I'm doing a check in the before hook, and forwarding them to a password change page if required. The problem is likely to be that the password change page (or otherwise) is a protected route in itself.

I did think about doing this as an automatic forward to a configurable URL if the password has expired, but I thought that was overcomplicating it and leaving it less flexible for the developer.

How about I make this clear in the documentation and give an example?

@racke
Copy link
Member

racke commented May 1, 2015

Yes, please clarify this in the documentation and provide an example.

@abeverley
Copy link
Collaborator Author

No problem, I've just pushed that now.

racke added a commit that referenced this pull request May 1, 2015
Add logged_in_user_password_expired keyword
@racke racke merged commit de84a4a into PerlDancer:master May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants