Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack_rasters() specifies resampling methods twice #27

Closed
mikemahoney218 opened this issue Jan 8, 2024 · 1 comment · Fixed by #30
Closed

stack_rasters() specifies resampling methods twice #27

mikemahoney218 opened this issue Jan 8, 2024 · 1 comment · Fixed by #30
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@mikemahoney218
Copy link
Collaborator

The arguments list of stack_rasters currently looks like this:

    resampling_method = "bilinear",
    band_names,
    gdalwarp_options = c(
        "-r", "bilinear",

This is created by #15 -- the gdalwarp_options resampling method argument only controls resampling when going from the VRT output to another format (unless the user also passes new extent or resolution options, I guess). The actual resampling worth caring about happens when creating the VRT.

Probably the next version should just drop this option from the gdalwarp_options vector? If the user is doing something complex enough that gdalwarp's resampling actually gets used, it seems fine that they're responsible for controlling it.

@mikemahoney218 mikemahoney218 added the bug an unexpected problem or unintended behavior label Jan 8, 2024
@mikemahoney218 mikemahoney218 added this to the next release milestone Jan 8, 2024
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant