Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EncodeUriComponent() when including user inputs as a URL parameter #2

Open
lanzone1 opened this issue Apr 26, 2024 · 0 comments
Open

Comments

@lanzone1
Copy link

When reviewing your template we've noticed that it is using user-defined parameters to build a URL. It's best practice to use encodeUri() if part of the URL path or encodeUriComponent() if used as a URL parameter.

The line in question is:

const url = 'https://lib.personaje.me/personaje.js?id=' + data.trackingId;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant