Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cg.fg.dotify is not a function #35

Closed
bandtank opened this issue Dec 23, 2018 · 2 comments
Closed

cg.fg.dotify is not a function #35

bandtank opened this issue Dec 23, 2018 · 2 comments

Comments

@bandtank
Copy link

bandtank commented Dec 23, 2018

I'm not sure what I've done wrong, but I'm seeing the following error when I try to use --fg:

$ js-callgraph --fg repositories/pse-timesheet/res/js/
/usr/local/lib/node_modules/@persper/js-callgraph/src/runner.js:157
            console.log(cg.fg.dotify());
                              ^

TypeError: cg.fg.dotify is not a function
    at Object.build (/usr/local/lib/node_modules/@persper/js-callgraph/src/runner.js:157:31)
    at Object.<anonymous> (/usr/local/lib/node_modules/@persper/js-callgraph/js-callgraph.js:117:5)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)
    at bootstrap_node.js:612:3

Using --cg with the same path appears to work as expected. npm is 6.5.0.

@gaborantal
Copy link
Contributor

Hello there @bandtank,

I checked your issue. The line calls a method dotify which is now not working as graph representation was completely replaced. I used serialize() provided by this representation to print out the flowgraph. In my recent PR, you can check out the fix and test yourself.

Cheers,
Gabor

@hezyin
Copy link
Member

hezyin commented Jan 16, 2019

A fix has been merged. Thanks for reporting! @bandtank

@hezyin hezyin closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants