Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic Sensors not created for all equipment: [Discharge Air Temperature is reporting Open instead of the actual temperature] #181

Closed
subtlybeast opened this issue Jul 12, 2022 · 14 comments · Fixed by #182

Comments

@subtlybeast
Copy link

Integration Version 0.2.10

Within the "Indoor Unit", the Sensor "System_iu_Discharge_Air_Temperature" reports "Open" when it should report a numeric value; Temperature, as measured from the Discharge Air Sensor, in the Temperature Unit that is set in the S30.

@PeteRager
Copy link
Owner

Thanks for the note, from what I can tell this is just what it reports. Here is the data from my system:

                        {
                            "diagnostic": {
                                "name": "Discharge Air Temperature",
                                "unit": "",
                                "value": "open"
                            },
                            "id": 7
                        },

To get the data from your system, follow the instructions for enabling message logging to a file in the readme.
https://github.com/PeteRager/lennoxs30#reporting-bugs

Restart HA or Reload the integration, wait a minute or two. Then look in the file for this message and/or post the file here.

In this context I believe the word "open" means there is no sensor installed. The other uses of "Open" (note the capitalized O), seem to indicate the switch, etc, is actually open.

When you say " as measured from the Discharge Air Sensor, in the Temperature Unit that is set in the S30.", do you see data in the S30 display that shows this temperature? If so it'd be good to know that value, perhaps we can then find it in the message log?

@subtlybeast
Copy link
Author

Thank YOU!
I found these in the logs, one similar to what you are showing:
{
"id": 10,
"diagnostic": {
"value": "open",
"name": "Discharge Air Temperature",
"unit": ""
}
},
The other, coming to a couple of hundred lines after is what we are looking for:
{
"id": 8,
"diagnostic": {
"value": "59.6",
"name": "Discharge Air Temperature",
"unit": "F"
}
},

@PeteRager
Copy link
Owner

PeteRager commented Jul 12, 2022

Super. Can you post your logfile here or email to me

I'll try to figure out why it isn't showing up.

@subtlybeast
Copy link
Author

Here goes
S30_Local.log

Thanks

@PeteRager
Copy link
Owner

Very cool. So your system have a zoning controller which is equipment Id 3. Right now the integration is not creating a device for it. That’ll need to be fixed.

However, it should be attempting to create a sensor.

It’s name should be System_3_Discharge_Air_Temperature

See if you can find that.

It may also be logging a warning in the home assistant log

    _LOGGER.warning(
        f"Unexpected equipment id [{self.eid}], please raise an issue and post a mesage log"
    )
    return {
        "identifiers": {(DOMAIN, self._system.unique_id())},
    }

But it’s also possible that whole path is broken because it’s never been tested. I’ll load your file into the simulator next day or so and see what comes up.

@subtlybeast
Copy link
Author

Makes sense, the Discharge Air Temperature appears under the Zoning Controller section on the S30 diagnostics screen, that might be why it is reading open now as the zoning controller is taking over it in my configuration, and the device is not created in the integration at this point.

in the home assistant log there is the
"Unexpected equipment id [{self.eid}], please raise an issue and post a mesage log"

This is cool - thank you :)

@PeteRager
Copy link
Owner

I've made some initial progress. Probably a week or so to get the changes done, maybe less. I'll keep you posted when I have something to share.

@PeteRager
Copy link
Owner

From what I can tell the second sensor should be getting created.

if you got into developer tools / states, do you see something similar to this?

sensor.System_3_Discharge_Air_Temperature

@subtlybeast
Copy link
Author

The only one I see under developer tools / states is
sensor.system_iu_discharge_air_temperature

@PeteRager
Copy link
Owner

Got the changes working, next step is testing and packaging for release. Here is what your system looks like with the changes.

Here is the device list. Note the zoning controller is showing up and the integration is pulling in the correct model numbers for the installed equipment.

devices

Here is the view of the zoning controller device. The diag sensors are showing up now and the serial number of the zoning controller is showing up under the device Hardware attribute (I changed the digits from what your serial number is)

zoning_device

Lastly here's a dashboard to more clearly show the new attributes.

diag_sensors

@PeteRager PeteRager changed the title Discharge Air Temperature is reporting Open instead of the actual temperature Diagnostic Sensors not created for all equipment: [Discharge Air Temperature is reporting Open instead of the actual temperature] Jul 18, 2022
@subtlybeast
Copy link
Author

NICE!
Thank you very much! Now I will be able to properly collect and see data points and hopefully tune that system

@PeteRager PeteRager linked a pull request Jul 18, 2022 that will close this issue
@PeteRager PeteRager reopened this Jul 19, 2022
@PeteRager
Copy link
Owner

Merging pull request, auto-closed. Creating release

@PeteRager
Copy link
Owner

PeteRager commented Jul 19, 2022

Release is here. On HA startup it’ll pull the new version of the lennoxs30api, this takes a few minutes.

Let me know how it goes.

https://github.com/PeteRager/lennoxs30/releases/tag/0.2.11

@subtlybeast
Copy link
Author

Installation went smooth, I can now see the Zoning Controler and the associated sensors reporting correctly!
Nicely done - thank you!
I will keep testing and playing around and will report back if I find something.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants