Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI and tests a little more useful #7

Merged
merged 1 commit into from Jun 24, 2022
Merged

Make CI and tests a little more useful #7

merged 1 commit into from Jun 24, 2022

Conversation

zombiepigdragon
Copy link
Contributor

This PR adds running the Clippy checks to CI and changes the matches! invocations in the unit tests for assert_eq!, causing failing tests to automatically print the expected and received values. On my machine, both Clippy and tests fail, but I think it's worth the time to mark the failures in CI rather than only seeing them locally.

@zombiepigdragon
Copy link
Contributor Author

zombiepigdragon commented Jun 23, 2022

Oops, made a typo in CI. It should work as intended now.

Copy link
Owner

@PeterPierinakos PeterPierinakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like PartialEq should indeed be implemented for TestStatusCode. PR looks good to me.

@PeterPierinakos PeterPierinakos merged commit 88135d7 into PeterPierinakos:main Jun 24, 2022
@zombiepigdragon zombiepigdragon deleted the testing_and_ci_cleanup branch June 24, 2022 13:26
PeterPierinakos added a commit that referenced this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants