New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update init.py #13

Closed

prakhar-goel wants to merge 1 commit into PetrDlouhy:master from prakhar-goel:master

prakhar-goel commented Dec 24, 2019

Fixed this error, caused by performing string manipulation on a function:

related_admin/__init__.py", line 69, in __new__
    if '__' in field[1:-1] and not hasattr(new_class, field):
TypeError: 'function' object is not subscriptable

list_display can also contain functions. Added check that fields in list_display are only strings.


          Update __init__.py

Fixed this error, caused by performing string manipulation on a function:
```
related_admin/__init__.py", line 69, in __new__
    if '__' in field[1:-1] and not hasattr(new_class, field):
TypeError: 'function' object is not subscriptable
```
`list_display` can also contain `functions`. Added check that fields in `list_display` are only strings.

Author

prakhar-goel commented Dec 24, 2019

Fixed this error, caused by performing string manipulation on a function:

related_admin/__init__.py", line 69, in __new__
    if '__' in field[1:-1] and not hasattr(new_class, field):
TypeError: 'function' object is not subscriptable

list_display can also contain functions. Added check that fields in list_display are only strings.

prakhar-goel mentioned this pull request

The code breaks when using methods as fields #11

Closed

coveralls commented Dec 24, 2019

Coverage decreased (-1.04%) to 98.958% when pulling 1439857 on prakhar-goel:master into babb9b8 on PetrDlouhy:master.

4 similar comments

coveralls commented Dec 24, 2019

Coverage decreased (-1.04%) to 98.958% when pulling 1439857 on prakhar-goel:master into babb9b8 on PetrDlouhy:master.

coveralls commented Dec 24, 2019

Coverage decreased (-1.04%) to 98.958% when pulling 1439857 on prakhar-goel:master into babb9b8 on PetrDlouhy:master.

coveralls commented Dec 24, 2019

Coverage decreased (-1.04%) to 98.958% when pulling 1439857 on prakhar-goel:master into babb9b8 on PetrDlouhy:master.

coveralls commented Dec 24, 2019

Coverage decreased (-1.04%) to 98.958% when pulling 1439857 on prakhar-goel:master into babb9b8 on PetrDlouhy:master.

Owner

PetrDlouhy commented Dec 24, 2019

@prakhar-goel Thank you very much for the fix. Can you please add test for this error?

Author

prakhar-goel commented Jan 29, 2020

Hi @PetrDlouhy, did you get a chance to approve the pull request please?

Author

prakhar-goel commented Jan 29, 2020

Ok just saw your previous comment regarding tests. I ain't a pro at writing tests. Can you please guide me.

Owner

PetrDlouhy commented Jul 15, 2020

I have reworked this and write the test. So I am closing the PR.

PetrDlouhy closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment