Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Replaced .view with .reshape on Attention #90

Merged
merged 1 commit into from Dec 12, 2019

Conversation

jmribeiro
Copy link
Contributor

Replaced .view with .reshape in Attention module in order to avoid RuntimeError: "view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.".

Replaced .view with .reshape in Attention module in order to avoid RuntimeError: "view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.".
@codecov-io
Copy link

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          63       63           
  Lines        1594     1594           
=======================================
  Hits         1505     1505           
  Misses         89       89
Impacted Files Coverage Δ
torchnlp/nn/attention.py 96.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46406d3...ec82cf1. Read the comment docs.

@PetrochukM PetrochukM merged commit 5cc4bb1 into PetrochukM:master Dec 12, 2019
@PetrochukM
Copy link
Owner

Sounds good. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants