Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Amber Updater #145

Open
brumik opened this issue Jun 2, 2024 · 7 comments
Open

[Feature] Amber Updater #145

brumik opened this issue Jun 2, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@brumik
Copy link
Contributor

brumik commented Jun 2, 2024

Make so that Amber can update itself.

@brumik brumik self-assigned this Jun 2, 2024
@brumik
Copy link
Contributor Author

brumik commented Jun 2, 2024

I was thinking of two possible ways to do it:

CLI command option:

amber --check-version

Current version: 1.0.0
Latest version: 1.2.0

Run amber --update to get the latest version

Manual command option:

amber ---check-version

Current version: 1.0.0
Latest version: 1.2.0

To update amber run:

curl -s "https://raw.githubusercontent.com/Ph0enixKM/AmberNative/master/setup/update.sh" | /usr/bin/env bash

@b1ek
Copy link
Member

b1ek commented Jun 2, 2024

shouldn't this kind of thing be done via the system's package manager?

@brumik
Copy link
Contributor Author

brumik commented Jun 3, 2024

I expect so if you installed it from one. Currently we have a script that is the "recommended" (or for most systems only) way to do it. So as I understood the task from the project we want something like this.

@Ph0enixKM
Copy link
Collaborator

Ph0enixKM commented Jun 3, 2024

Well this is a good question. When Amber was first created I was not focusing on maintaining packages. Now since there are propositions to maintain Amber via Homebrew tap or AUR packages - this could be unnecessary.

However... I still think that Amber should at least inform the user about new updates in some way and it should instruct them on how to update it.

I think that this issue should at least cover the ability to check the latest version. If do something like --check-version it should fetch the latest version available.

@b1ek
Copy link
Member

b1ek commented Jun 3, 2024

inform the user about new updates

when would be the right time to do this, though? sending an HTTP request somewhere each compilation seems very unnecessary and time consuming. also the users might not like the excessive telemetry

i cant really think of a language/compiler/interpreter that informs the user about a new update tbh

@Ph0enixKM
Copy link
Collaborator

I think that creating brew tap, PPA repository etc. Would be of higher priority right now. We should discuss that more on GH Discussions

@Ph0enixKM
Copy link
Collaborator

Ph0enixKM commented Jun 3, 2024

when would be the right time to do this, though? sending an HTTP request somewhere each compilation seems very unnecessary and time consuming. also the users might not like the excessive telemetry

@b1ek This could happen when user checks the compiler version. Although I'm not sure if people would be against that. We can always just leave the --check-version or --latest to get the latest version by itself. Not necessarily try to hide or sneak some telemetry behind the scenes.

@Mte90 Mte90 added the enhancement New feature or request label Jun 24, 2024
@Ph0enixKM Ph0enixKM changed the title ✨ Amber Updater [Feature] Amber Updater Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants