Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better security #3093

Closed
prdatur opened this issue Feb 21, 2023 · 1 comment
Closed

Better security #3093

prdatur opened this issue Feb 21, 2023 · 1 comment
Assignees
Labels
Projects
Milestone

Comments

@prdatur
Copy link

prdatur commented Feb 21, 2023

I checked the obs browser pages (alerts and polls) and saw that the authToken for the websocket is stored within a js file globally readable.

The authToken should be generated (or stored in botconfig) onetime which is then appended to the browser source url as a GET-Parameter.
It could also be a button to generate / regenerate the authToken within the panel.

Yes, the authToken is then present within the Link, but as a streamer the browser source url is not shown.
Currently, any user who knows a phantombot url can just connect to the websocket and send commands without authentication.

@gmt2001 gmt2001 self-assigned this Feb 21, 2023
@gmt2001 gmt2001 added the bug label Feb 21, 2023
@gmt2001 gmt2001 added this to Needs triage in Bug Triage via automation Feb 21, 2023
@gmt2001 gmt2001 added this to the 3.7.0 milestone Feb 21, 2023
@gmt2001 gmt2001 moved this from Needs triage to High priority in Bug Triage Feb 21, 2023
Bug Triage automation moved this from High priority to Closed Feb 27, 2023
@prdatur
Copy link
Author

prdatur commented Mar 2, 2023

I do not really understand why the given changes makes the socket read only, but also if i assume it is now read only, read only means that any user could ready things he should not be able to.
For me this Issue is not closed, the auth key is still not present in the browser url, instead it is directly injected for everyone who knows the url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bug Triage
  
Closed
Development

No branches or pull requests

2 participants